Skip to content

Number converters: convert more than one digit at a time #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2018
Merged

Number converters: convert more than one digit at a time #149

merged 1 commit into from
Nov 5, 2018

Conversation

bact
Copy link
Member

@bact bact commented Nov 5, 2018

  • separated functions to smaller files
  • add more test cases

@bact
Number converters
ace9aee 
- convert more than one digit at a time
- separated functions to smaller files
- add more test cases
@coveralls
Copy link

Coverage Status

Coverage increased (+1.09%) to 67.536% when pulling ace9aee on bact:dev into 3a0cc37 on PyThaiNLP:dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.09%) to 67.536% when pulling ace9aee on bact:dev into 3a0cc37 on PyThaiNLP:dev.

@bact bact merged commit 978295f into PyThaiNLP:dev Nov 5, 2018
@wannaphong wannaphong mentioned this pull request Nov 5, 2018
Closed
@wannaphong wannaphong added this to the 1.8 milestone Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @coveralls @wannaphong