--buffer-deallocation is removed.

The upstream suggestion is to use -buffer-deallocation-pipeline

llvm/llvm-project#126366
https://discourse.llvm.org/t/psa-bufferization-new-buffer-deallocation-pipeline/73375

However, this breaks more or less everything for us, since the --ownership-based-buffer-deallocation
pass blanket-ly fails for ops with unknown memory effects

https://github.com/llvm/llvm-project/blob/da4958ae2b384c2a027cf20c67b7e211d39fcbfe/mlir/lib/Dialect/Bufferization/Transforms/OwnershipBasedBufferDeallocation.cpp#L523

Maybe we leave this as TODO...

Author: paul0403

frontend/catalyst/pipelines.py

@@ -240,7 +240,7 @@ def get_bufferization_stage(options: CompileOptions) -> List[str]:
         "func.func(buffer-hoisting)",
         "func.func(buffer-loop-hoisting)",
         "func.func(promote-buffers-to-stack)",
-        "ownership-based-buffer-deallocation",
+        # "buffer-deallocation-pipeline",
         "convert-arraylist-to-memref",
         "convert-bufferization-to-memref",
         "canonicalize",  # Must be after convert-bufferization-to-memref

mlir/lib/Catalyst/Transforms/BufferizableOpInterfaceImpl.cpp

@@ -75,7 +75,7 @@ struct PrintOpInterface
 struct CustomCallOpInterface
     : public bufferization::BufferizableOpInterface::ExternalModel<CustomCallOpInterface,
                                                                    CustomCallOp> {
-    bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
+    // bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
 
     bool bufferizesToMemoryRead(Operation *op, OpOperand &opOperand,
                                 const bufferization::AnalysisState &state) const
@@ -251,7 +251,7 @@ void convertTypes(SmallVector<Type> inTypes, SmallVector<Type> &convertedResults
 struct CallbackCallOpInterface
     : public bufferization::BufferizableOpInterface::ExternalModel<CallbackCallOpInterface,
                                                                    CallbackCallOp> {
-    bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
+    // bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
 
     bool bufferizesToMemoryRead(Operation *op, OpOperand &opOperand,
                                 const bufferization::AnalysisState &state) const

mlir/lib/Driver/Pipelines.cpp

@@ -86,7 +86,7 @@ void createBufferizationPipeline(OpPassManager &pm)
     pm.addNestedPass<mlir::func::FuncOp>(mlir::bufferization::createBufferHoistingPass());
     pm.addNestedPass<mlir::func::FuncOp>(mlir::bufferization::createBufferLoopHoistingPass());
     pm.addNestedPass<mlir::func::FuncOp>(mlir::bufferization::createPromoteBuffersToStackPass());
-    pm.addPass(mlir::bufferization::createOwnershipBasedBufferDeallocationPass());
+    // pm.addPass(mlir::bufferization::createOwnershipBasedBufferDeallocationPass());
     pm.addPass(catalyst::createArrayListToMemRefPass());
     pm.addPass(mlir::createConvertBufferizationToMemRefPass());
     pm.addPass(mlir::createCanonicalizerPass());

mlir/lib/Quantum/Transforms/BufferizableOpInterfaceImpl.cpp

@@ -177,7 +177,7 @@ struct SampleOpInterface
         return false;
     }
 
-    bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
+    // bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
 
     bufferization::AliasingValueList
     getAliasingValues(Operation *op, OpOperand &opOperand,
@@ -227,7 +227,7 @@ struct CountsOpInterface
         return false;
     }
 
-    bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
+    // bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
 
     bufferization::AliasingValueList
     getAliasingValues(Operation *op, OpOperand &opOperand,
@@ -287,7 +287,7 @@ struct ProbsOpInterface
         return false;
     }
 
-    bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
+    // bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
 
     bufferization::AliasingValueList
     getAliasingValues(Operation *op, OpOperand &opOperand,
@@ -340,7 +340,7 @@ struct StateOpInterface
         return false;
     }
 
-    bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
+    // bool bufferizesToAllocation(Operation *op, Value value) const { return true; }
 
     bufferization::AliasingValueList
     getAliasingValues(Operation *op, OpOperand &opOperand,