Be consistent with the name - either "op" or "messageType".

(also some changes for "End comments with periods.")

Author: vbBerni

PcapDotNet/src/PcapDotNet.Packets.TestUtils/RandomDhcpExtensions.cs

@@ -21,7 +21,7 @@ public static DhcpLayer NextDhcpLayer(this Random random)
             const int MaxOptions = 10;
 
             DhcpLayer dhcpLayer = new DhcpLayer();
-            dhcpLayer.MessageType = random.NextEnum<DhcpMessageType>();
+            dhcpLayer.MessageOPCode = random.NextEnum<DhcpMessageOPCode>();
             dhcpLayer.HardwareType = random.NextEnum<ArpHardwareType>(Enum.GetValues(typeof(ArpHardwareType)).Cast<ArpHardwareType>().Where(p => ((short)p) > byte.MaxValue));
             dhcpLayer.HardwareAddressLength = random.NextByte(16);
             dhcpLayer.Hops = random.NextByte();

PcapDotNet/src/PcapDotNet.Packets/Dhcp/DhcpDatagram.cs

@@ -76,9 +76,9 @@ private static class Offset
         /// RFC 2131.
         /// Message op code.
         /// </summary>
-        public DhcpMessageType MessageType
+        public DhcpMessageOPCode MessageOPCode
         {
-            get { return (DhcpMessageType)this[Offset.Op]; }
+            get { return (DhcpMessageOPCode)this[Offset.Op]; }
         }
 
         /// <summary>
@@ -254,7 +254,7 @@ public override ILayer ExtractLayer()
         {
             return new DhcpLayer
             {
-                MessageType = MessageType,
+                MessageOPCode = MessageOPCode,
                 HardwareType = HardwareType,
                 HardwareAddressLength = HardwareAddressLength,
                 Hops = Hops,
@@ -290,9 +290,9 @@ internal static int GetLength(bool isDhcp, IList<DhcpOption> options)
             return length;
         }
 
-        internal static void Write(byte[] buffer, int offset, DhcpMessageType messageType, ArpHardwareType hardwareType, byte hardwareAddressLength, byte hops, uint transactionId, ushort secondsElapsed, DhcpFlags flags, IpV4Address clientIpAddress, IpV4Address yourClientIpAddress, IpV4Address nextServerIpAddress, IpV4Address relayAgentIpAddress, DataSegment clientHardwareAddress, string serverHostName, string bootFileName, bool isDhcp, IList<DhcpOption> options)
+        internal static void Write(byte[] buffer, int offset, DhcpMessageOPCode messageOPCode, ArpHardwareType hardwareType, byte hardwareAddressLength, byte hops, uint transactionId, ushort secondsElapsed, DhcpFlags flags, IpV4Address clientIpAddress, IpV4Address yourClientIpAddress, IpV4Address nextServerIpAddress, IpV4Address relayAgentIpAddress, DataSegment clientHardwareAddress, string serverHostName, string bootFileName, bool isDhcp, IList<DhcpOption> options)
         {
-            buffer.Write(ref offset, (byte)messageType);
+            buffer.Write(ref offset, (byte)messageOPCode);
             buffer.Write(ref offset, (byte)hardwareType);
             buffer.Write(ref offset, hardwareAddressLength);
             buffer.Write(ref offset, hops);

PcapDotNet/src/PcapDotNet.Packets/Dhcp/DhcpFlags.cs

@@ -24,13 +24,13 @@ public enum DhcpFlags : ushort
     {
         /// <summary>
         /// RFCs 2131.
-        /// Response as Unicast
+        /// Response as Unicast.
         /// </summary>
         Unicast = 0 << 15,
 
         /// <summary>
         /// RFCs 2131.
-        /// Response as Broadcast
+        /// Response as Broadcast.
         /// </summary>
         Broadcast = 1 << 15
     }

PcapDotNet/src/PcapDotNet.Packets/Dhcp/DhcpLayer.cs

@@ -20,7 +20,7 @@ public sealed class DhcpLayer : SimpleLayer, IEquatable<DhcpLayer>
         /// <summary>
         /// Message op code.
         /// </summary>
-        public DhcpMessageType MessageType { get; set; }
+        public DhcpMessageOPCode MessageOPCode { get; set; }
 
         /// <summary>
         /// Hardware address type.
@@ -137,7 +137,7 @@ public override int Length
         protected override void Write(byte[] buffer, int offset)
         {
             DhcpDatagram.Write(buffer, offset,
-                              MessageType, HardwareType, HardwareAddressLength, Hops, TransactionId, SecondsElapsed, DhcpFlags, ClientIpAddress, YourClientIpAddress,
+                              MessageOPCode, HardwareType, HardwareAddressLength, Hops, TransactionId, SecondsElapsed, DhcpFlags, ClientIpAddress, YourClientIpAddress,
                               NextServerIpAddress, RelayAgentIpAddress, ClientHardwareAddress, ServerHostName, BootFileName, IsDhcp, Options);
         }
 
@@ -147,7 +147,7 @@ protected override void Write(byte[] buffer, int offset)
         public bool Equals(DhcpLayer other)
         {
             return other != null &&
-                   Equals(MessageType, other.MessageType) &&
+                   Equals(MessageOPCode, other.MessageOPCode) &&
                    Equals(HardwareType, other.HardwareType) &&
                    Equals(HardwareAddressLength, other.HardwareAddressLength) &&
                    Equals(Hops, other.Hops) &&

PcapDotNet/src/PcapDotNet.Packets/Dhcp/DhcpMessageType.cs

@@ -10,17 +10,17 @@ namespace PcapDotNet.Packets.Dhcp
     /// RFCs 2131.
     /// </summary>
     [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1008:EnumsShouldHaveZeroValue")]
-    public enum DhcpMessageType : byte
+    public enum DhcpMessageOPCode : byte
     {
         /// <summary>
         /// RFC 2131.
-        /// Indicates a Boot Request
+        /// Indicates a Boot Request.
         /// </summary>
         BootRequest = 1,
 
         /// <summary>
         /// RFC 2131.
-        /// Indicates a Boot Reply
+        /// Indicates a Boot Reply.
         /// </summary>
         BootReply = 2
     }