Skip to content

Commit ae764b3

Browse files
radazzouzsteviki
andauthored
Remove the trial license key requirement (#403)
* Remove trial license key requirement * Apply suggestions from code review Co-authored-by: Stefan Kieleithner <[email protected]> * Bump version number to 1.31.0 * Update README.md Co-authored-by: Stefan Kieleithner <[email protected]> * Update Github pull request template Co-authored-by: Stefan Kieleithner <[email protected]>
1 parent d5a66ca commit ae764b3

File tree

15 files changed

+223
-233
lines changed

15 files changed

+223
-233
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33

44
# Acceptance Criteria
55

6-
- [ ] When approved, right before merging, rebase with master and increment the package version in `package.json`, `package-lock.json`, `samples/Catalog/package.json`, and `samples/NativeCatalog/package.json` (see example commit: https://github.com/PSPDFKit/react-native/pull/389/commits/ae027329b5380906fa778354945178c7e92730a4).
6+
- [ ] When approved, right before merging, rebase with master and increment the package version in `package.json`, `package-lock.json`, `samples/Catalog/package.json`, `samples/Catalog/yarn.lock`, `samples/NativeCatalog/package.json`, and `samples/NativeCatalog/yarn.lock` (see example commit: https://github.com/PSPDFKit/react-native/pull/403/commits/b32b4edd97ee9b49c51c8b932e2bf477744c2b24).
77
- [ ] Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

README.md

Lines changed: 211 additions & 217 deletions
Large diffs are not rendered by default.

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* Contains gradle configuration constants
1616
*/
1717
ext {
18-
PSPDFKIT_VERSION = '6.6.0'
18+
PSPDFKIT_VERSION = '6.6.2'
1919
}
2020

2121
buildscript {

android/src/main/java/com/pspdfkit/react/PSPDFKitModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ public void run() {
182182
}
183183

184184
@ReactMethod
185-
public void setLicenseKey(@NonNull String licenseKey) {
185+
public void setLicenseKey(@Nullable String licenseKey) {
186186
PSPDFKit.initialize(getReactApplicationContext().getApplicationContext(), licenseKey);
187187
}
188188

ios/RCTPSPDFKit/RCTPSPDFKitManager.m

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,9 @@ @implementation RCTPSPDFKitManager
2424

2525
RCT_EXPORT_MODULE(PSPDFKit)
2626

27-
RCT_REMAP_METHOD(setLicenseKey, setLicenseKey:(NSString *)licenseKey resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
28-
if (licenseKey.length > 0) {
29-
[PSPDFKitGlobal setLicenseKey:licenseKey];
30-
resolve(@(YES));
31-
} else {
32-
reject(@"error", @"Invalid License Key.", nil);
33-
}
27+
RCT_REMAP_METHOD(setLicenseKey, setLicenseKey:(nullable NSString *)licenseKey resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
28+
[PSPDFKitGlobal setLicenseKey:licenseKey];
29+
resolve(@(YES));
3430
}
3531

3632
RCT_REMAP_METHOD(present, present:(PSPDFDocument *)document withConfiguration:(PSPDFConfiguration *)configuration resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-pspdfkit",
3-
"version": "1.30.18",
3+
"version": "1.31.0",
44
"description": "A React Native module for the PSPDFKit library.",
55
"keywords": [
66
"react native",

samples/Catalog/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "Catalog",
3-
"version": "1.30.18",
3+
"version": "1.31.0",
44
"private": true,
55
"scripts": {
66
"start": "react-native start",

samples/Catalog/yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5420,7 +5420,7 @@ react-native-permissions@^1.1.1:
54205420
integrity sha512-t0Ujm177bagjUOSzhpmkSz+LqFW04HnY9TeZFavDCmV521fQvFz82aD+POXqWsAdsJVOK3umJYBNNqCjC3g0hQ==
54215421

54225422
"react-native-pspdfkit@file:../..":
5423-
version "1.30.18"
5423+
version "1.31.0"
54245424

54255425
react-native-qrcode-scanner@^1.2.1:
54265426
version "1.2.1"

samples/NativeCatalog/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "NativeCatalog",
3-
"version": "1.30.18",
3+
"version": "1.31.0",
44
"private": true,
55
"scripts": {
66
"android": "react-native run-android",

0 commit comments

Comments
 (0)