Skip to content

Commit 6215cea

Browse files
authored
Fix set toolbar promise. (#208)
Mistakenly did not handle the promise for set toolbar and therefore it was never fired. Same is true for the error.
1 parent be86e31 commit 6215cea

File tree

5 files changed

+14
-16
lines changed

5 files changed

+14
-16
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-pspdfkit",
3-
"version": "1.23.4",
3+
"version": "1.23.5",
44
"description": "A React Native module for the PSPDFKit library.",
55
"keywords": [
66
"react native",

samples/Catalog/Catalog.windows.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,9 @@ class PdfViewToolbarCustomizationScreen extends Component<{}> {
441441
</View>
442442
<View style={styles.button}>
443443
<Button onPress={() =>
444-
this.refs.pdfView.setToolbarItems([{type: "ink"}])} title="Set Toolbar Items"/>
444+
this.refs.pdfView.setToolbarItems([{type: "ink"}]).then(() => {
445+
alert("Toolbar Items set.");
446+
})} title="Set Toolbar Items"/>
445447
</View>
446448
</View>
447449
<Image

samples/Catalog/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "Catalog",
3-
"version": "1.23.4",
3+
"version": "1.23.5",
44
"private": true,
55
"scripts": {
66
"start": "node node_modules/react-native/local-cli/cli.js start"

windows/ReactNativePSPDFKit/ReactNativePSPDFKit/PDFViewPage.xaml.cs

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -138,18 +138,14 @@ internal void GetToolbarItems(int requestId)
138138

139139
internal async Task SetToolbarItems(int requestId, string toolbarItemsJson)
140140
{
141-
try
142-
{
143-
var toolbarItems =
144-
PSPDFKit.UI.ToolbarComponents.Factory.FromJsonArray(JsonArray.Parse(toolbarItemsJson));
145-
await Pdfview.Controller.SetToolbarItemsAsync(toolbarItems.ToList());
146-
}
147-
catch (Exception e)
148-
{
149-
this.GetReactContext().GetNativeModule<UIManagerModule>().EventDispatcher.DispatchEvent(
150-
new PdfViewDataReturnedEvent(this.GetTag(), requestId, e.Message)
151-
);
152-
}
141+
await RunOperationAndFireEvent(requestId,
142+
async () =>
143+
{
144+
var toolbarItems =
145+
PSPDFKit.UI.ToolbarComponents.Factory.FromJsonArray(JsonArray.Parse(toolbarItemsJson));
146+
await Pdfview.Controller.SetToolbarItemsAsync(toolbarItems.ToList());
147+
}
148+
);
153149
}
154150

155151
internal async Task CreateAnnotation(int requestId, string annotationJsonString)

0 commit comments

Comments
 (0)