unconditionally disconnect after monitor failure

lhoward · lhoward · commit ef6087e4d051 · 2024-11-28T18:29:38.000+11:00
not just if automaticReconnect is enabled
diff --git a/Sources/SwiftOCA/OCP.1/Ocp1Connection+Connect.swift b/Sources/SwiftOCA/OCP.1/Ocp1Connection+Connect.swift
@@ -350,10 +350,10 @@ extension Ocp1Connection {
     if _connectionState.value != .notConnected {
       // don't update connection state if we were explicitly disconnected
       _updateConnectionState(error.ocp1ConnectionState)
+      try await _disconnectDeviceAfterConnectionFailure()
     }
 
     if _automaticReconnect, error._isRecoverableConnectionError {
-      try await _disconnectDeviceAfterConnectionFailure()
       Task.detached { try await self.reconnectDeviceWithBackoff() }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -350,10 +350,10 @@ extension Ocp1Connection {`
`350`	`350`	`if _connectionState.value != .notConnected {`
`351`	`351`	`// don't update connection state if we were explicitly disconnected`
`352`	`352`	`_updateConnectionState(error.ocp1ConnectionState)`
	`353`	`+ try await _disconnectDeviceAfterConnectionFailure()`
`353`	`354`	`}`
`354`	`355`
`355`	`356`	`if _automaticReconnect, error._isRecoverableConnectionError {`
`356`		`- try await _disconnectDeviceAfterConnectionFailure()`
`357`	`357`	`Task.detached { try await self.reconnectDeviceWithBackoff() }`
`358`	`358`	`}`
`359`	`359`	`}`