Merge pull request #14149 from LoveChauhan-18/fix-init-dest-warning

gdalwarp: change INIT_DEST=NO_DATA warning to failure

Author: rouault

alg/gdalwarpoperation.cpp

@@ -845,12 +845,9 @@ CPLErr GDALWarpOperation::InitializeDestinationBuffer(void *pDstBuffer,
         {
             if (psOptions->padfDstNoDataReal == nullptr)
             {
-                // TODO: Change to CE_Failure and error out for GDAL 3.13
-                // See https://github.com/OSGeo/gdal/pull/12189
-                CPLError(CE_Warning, CPLE_AppDefined,
+                CPLError(CE_Failure, CPLE_AppDefined,
                          "INIT_DEST was set to NO_DATA, but a NoData value was "
-                         "not defined. This warning will become a failure in a "
-                         "future GDAL release.");
+                         "not defined.");
             }
             else
             {

autotest/utilities/test_gdalwarp_lib.py

@@ -4553,9 +4553,7 @@ def test_gdalwarp_lib_init_dest_invalid(tmp_vsimem, init_dest):
 
 def test_gdalwarp_lib_init_dest_nodata_invalid(tmp_vsimem):
 
-    # TODO: switch from warning to failure in GDAL 3.12
-    # with pytest.raises(Exception, match="NoData value was not defined"):
-    with gdaltest.error_raised(gdal.CE_Warning, "NoData value was not defined"):
+    with gdaltest.error_raised(gdal.CE_Failure, "NoData value was not defined"):
         gdal.Warp(
             tmp_vsimem / "out.tif",
             "../gcore/data/byte.tif",