[MIG] stock_account_operating_unit: Migration to 18.0

Author: AtaponDew

stock_account_operating_unit/__manifest__.py

@@ -7,13 +7,17 @@
     "name": "Stock account moves with Operating Unit",
     "summary": "Create journal entries in moves between internal locations "
     "with different operating units.",
-    "version": "15.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Generic Modules/Sales & Purchases",
     "author": "Eficent Business and IT Consulting Services S.L., "
     "Serpent Consulting Services Pvt. Ltd.,"
     "Odoo Community Association (OCA)",
     "license": "LGPL-3",
     "website": "https://github.com/OCA/operating-unit",
-    "depends": ["stock_operating_unit", "account_operating_unit", "stock_account"],
+    "depends": [
+        "stock_operating_unit",
+        "account_operating_unit",
+        "stock_account",
+    ],
     "installable": True,
 }

stock_account_operating_unit/model/stock_move.py

@@ -2,7 +2,7 @@
 # - Jordi Ballester Alomar
 # © 2019 Serpent Consulting Services Pvt. Ltd. - Sudhir Arya
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
-from odoo import _, exceptions, models
+from odoo import exceptions, models
 
 
 class StockMove(models.Model):
@@ -36,36 +36,41 @@ def _generate_valuation_lines_data(
                 self.operating_unit_id
                 and self.operating_unit_dest_id
                 and self.operating_unit_id != self.operating_unit_dest_id
-                and debit_line_vals["account_id"] != credit_line_vals["account_id"]
+                and debit_line_vals["account_id"]
+                != credit_line_vals["account_id"]
             ):
                 raise exceptions.UserError(
-                    _(
+                    self.env._(
                         "You cannot create stock moves involving separate source"
                         " and destination accounts related to different "
                         "operating units."
                     )
                 )
 
             if not self.operating_unit_dest_id and not self.operating_unit_id:
-                ou_id = (
-                    self.picking_id.picking_type_id.warehouse_id.operating_unit_id.id
-                )
+                ou_id = self.picking_id.picking_type_id.warehouse_id.operating_unit_id.id
             else:
                 ou_id = False
 
             debit_line_vals["operating_unit_id"] = (
-                ou_id or self.operating_unit_dest_id.id or self.operating_unit_id.id
+                ou_id
+                or self.operating_unit_dest_id.id
+                or self.operating_unit_id.id
             )
             credit_line_vals["operating_unit_id"] = (
-                ou_id or self.operating_unit_id.id or self.operating_unit_dest_id.id
+                ou_id
+                or self.operating_unit_id.id
+                or self.operating_unit_dest_id.id
             )
             rslt = {
                 "credit_line_vals": credit_line_vals,
                 "debit_line_vals": debit_line_vals,
             }
             if price_diff_line_vals:
                 price_diff_line_vals["operating_unit_id"] = (
-                    ou_id or self.operating_unit_id.id or self.operating_unit_dest_id.id
+                    ou_id
+                    or self.operating_unit_id.id
+                    or self.operating_unit_dest_id.id
                 )
                 rslt["price_diff_line_vals"] = price_diff_line_vals
             return rslt
@@ -86,7 +91,8 @@ def _action_done(self, cancel_backorder=False):
                 # from/to non-internal location
                 if (
                     move.location_id.company_id
-                    and move.location_id.company_id == move.location_dest_id.company_id
+                    and move.location_id.company_id
+                    == move.location_dest_id.company_id
                     and move.operating_unit_id != move.operating_unit_dest_id
                 ):
                     (
@@ -101,7 +107,8 @@ def _action_done(self, cancel_backorder=False):
                         move.product_id.standard_price,
                         acc_valuation,
                         acc_valuation,
-                        _("%s - OU Move") % move.product_id.display_name,
+                        self.env._("%s - OU Move")
+                        % move.product_id.display_name,
                     )
                     am = (
                         self.env["account.move"]
@@ -113,7 +120,8 @@ def _action_done(self, cancel_backorder=False):
                                 "journal_id": journal_id,
                                 "line_ids": move_lines,
                                 "company_id": move.company_id.id,
-                                "ref": move.picking_id and move.picking_id.name,
+                                "ref": move.picking_id
+                                and move.picking_id.name,
                                 "stock_move_id": move.id,
                             }
                         )

stock_account_operating_unit/tests/test_stock_account_operating_unit.py

@@ -8,8 +8,8 @@
 
 
 class TestStockAccountOperatingUnit(TestStockCommon):
-    def setUp(self):
-        super().setUp()
+    def setUpClass(self):
+        super().setUpClass()
         self.res_groups = self.env["res.groups"]
         self.res_users_model = self.env["res.users"]
         self.aml_model = self.env["account.move.line"]
@@ -56,12 +56,16 @@ def setUp(self):
         name = "Goods Received Not Invoiced"
         code = "grni"
         acc_type = self.env.ref("account.data_account_type_equity")
-        self.account_grni = self._create_account(acc_type, name, code, self.company)
+        self.account_grni = self._create_account(
+            acc_type, name, code, self.company
+        )
         # Create account for Cost of Goods Sold
         name = "Cost of Goods Sold"
         code = "cogs"
         acc_type = self.env.ref("account.data_account_type_expenses")
-        self.account_cogs_id = self._create_account(acc_type, name, code, self.company)
+        self.account_cogs_id = self._create_account(
+            acc_type, name, code, self.company
+        )
         # Create account for Inventory
         name = "Inventory"
         code = "inventory"
@@ -146,7 +150,9 @@ def _create_product(self):
         )
         return product
 
-    def _create_picking(self, user, ou_id, picking_type, src_loc_id, dest_loc_id):
+    def _create_picking(
+        self, user, ou_id, picking_type, src_loc_id, dest_loc_id
+    ):
         """Create a Picking."""
         picking = self.picking_model.with_user(user.id).create(
             {
@@ -204,7 +210,8 @@ def _check_account_balance(
             self.assertEqual(
                 balance,
                 expected_balance,
-                "Balance is not %s for all Operating Units." % str(expected_balance),
+                "Balance is not %s for all Operating Units."
+                % str(expected_balance),
             )
 
     def _get_balance(self, domain):
@@ -258,7 +265,9 @@ def test_pickings(self):
         # irrespective of the OU
         expected_balance = -1.0
         self._check_account_balance(
-            self.account_grni.id, operating_unit=None, expected_balance=expected_balance
+            self.account_grni.id,
+            operating_unit=None,
+            expected_balance=expected_balance,
         )
         # GL account ‘Goods Received Not Invoiced’ has balance -1 on Main OU
         expected_balance = -1.0
@@ -312,7 +321,9 @@ def test_pickings(self):
         # irrespective of the OU
         expected_balance = -2.0
         self._check_account_balance(
-            self.account_grni.id, operating_unit=None, expected_balance=expected_balance
+            self.account_grni.id,
+            operating_unit=None,
+            expected_balance=expected_balance,
         )
         # GL account ‘Goods Received Not Invoiced’ has balance -1 on Main OU
         expected_balance = -1.0