Merge pull request #8418 from NuGet/dev

[ReleasePrep][2020.02.15] RI of dev into master

Author: loic-sharma

src/AccountDeleter/Configuration/GalleryConfiguration.cs

@@ -108,7 +108,6 @@ public string SiteRoot
         public string EmbeddedIconUrlTemplate { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public bool SelfServiceAccountDeleteEnabled { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public string DeploymentLabel { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
-        public string UsabillaFeedbackButtonId { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public int? MinWorkerThreads { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public int? MaxWorkerThreads { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public int? MinIoThreads { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }

src/Bootstrap/dist/css/bootstrap-theme.css

@@ -24,10 +24,6 @@
   width: device-width;
 }
 
-// See: https://stackoverflow.com/a/19706857
-body {
-  -ms-overflow-style: scrollbar;
-}
 
 // Visibility utilities
 // Note: Deprecated .visible-xs, .visible-sm, .visible-md, and .visible-lg as of v3.2.0

src/Bootstrap/dist/css/bootstrap.css

@@ -417,17 +417,6 @@ img.reserved-indicator-icon {
   }
 }
 
-.usabilla-button {
-  top: auto !important;
-  margin-top: -65px;
-  bottom: 20%;
-  width: 40px;
-  height: 130px;
-  position: fixed;
-  z-index: 99999;
-  right: 0;
-}
-
 .sortable {
 	cursor: pointer;
 }

src/Bootstrap/less/responsive-utilities.less

@@ -65,7 +65,7 @@
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation">
-      <Version>2.82.0</Version>
+      <Version>2.84.0</Version>
     </PackageReference>
   </ItemGroup>
   <ItemGroup>

src/Bootstrap/less/theme/base.less

@@ -89,7 +89,7 @@
       <Version>4.3.0-dev-3612825</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Cursor">
-      <Version>2.82.0</Version>
+      <Version>2.84.0</Version>
     </PackageReference>
   </ItemGroup>
   <ItemGroup>

src/DatabaseMigrationTools/DatabaseMigrationTools.csproj

@@ -47,7 +47,7 @@
       <Version>5.8.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.FeatureFlags">
-      <Version>2.82.0</Version>
+      <Version>2.84.0</Version>
     </PackageReference>
     <PackageReference Include="WindowsAzure.Storage">
       <Version>9.3.3</Version>
@@ -56,13 +56,13 @@
 
   <ItemGroup Condition="'$(TargetFramework)' == 'net472'">
     <PackageReference Include="NuGet.Services.Messaging.Email">
-      <Version>2.82.0</Version>
+      <Version>2.84.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation">
-      <Version>2.82.0</Version>
+      <Version>2.84.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.Services.Validation.Issues">
-      <Version>2.82.0</Version>
+      <Version>2.84.0</Version>
     </PackageReference>
     <PackageReference Include="NuGet.StrongName.elmah.corelibrary">
       <Version>1.2.2</Version>

src/GitHubVulnerabilities2Db/GitHubVulnerabilities2Db.csproj

@@ -406,8 +406,6 @@ public string ExternalBrandingMessage
         [DefaultValue(null)]
         public string DeploymentLabel { get; set; }
 
-        public string UsabillaFeedbackButtonId { get; set; }
-
         [DefaultValue(null)]
         public int? MinWorkerThreads { get; set; }
         [DefaultValue(null)]

src/NuGetGallery.Core/NuGetGallery.Core.csproj

@@ -39,7 +39,6 @@ public class FeatureFlagService : IFeatureFlagService
         private const string ODataCacheDurationsFeatureName = GalleryPrefix + "ODataCacheDurations";
         private const string ShowEnable2FADialog = GalleryPrefix + "ShowEnable2FADialog";
         private const string Get2FADismissFeedback = GalleryPrefix + "Get2FADismissFeedback";
-        private const string UsabillaOnEveryPageFeatureName = GalleryPrefix + "UsabillaEveryPage";
         private const string PackageRenamesFeatureName = GalleryPrefix + "PackageRenames";
         private const string EmbeddedReadmeFlightName = GalleryPrefix + "EmbeddedReadmes";
         private const string LicenseMdRenderingFlightName = GalleryPrefix + "LicenseMdRendering";
@@ -215,11 +214,6 @@ public bool IsGet2FADismissFeedbackEnabled()
             return _client.IsEnabled(Get2FADismissFeedback, defaultValue: false);
         }
 
-        public bool IsUsabillaButtonEnabledOnEveryPage()
-        {
-            return _client.IsEnabled(UsabillaOnEveryPageFeatureName, defaultValue: false);
-        }
-
         public bool IsPackageRenamesEnabled(User user)
         {
             return _client.IsEnabled(PackageRenamesFeatureName, user, defaultValue: false);