refactor: 코드 리뷰 피드백 반영

- useEffect 의존성 배열 개선 (optional chaining 제거)
- trackPageView를 trackViewPage로 리네이밍 및 이벤트명 내부 고정

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: youngminss

app/gathering/[accessKey]/opinion/complete/CompleteViewContainer.tsx

@@ -3,7 +3,7 @@
 import { useEffect } from "react";
 import { useParams, redirect } from "next/navigation";
 
-import { trackCtaClick, trackPageView } from "#/components/analytics";
+import { trackCtaClick, trackViewPage } from "#/components/analytics";
 import { Button } from "#/components/button";
 import { Layout } from "#/components/layout";
 import {
@@ -31,15 +31,15 @@ export function CompleteViewContainer() {
 	};
 
 	useEffect(() => {
-		if (!isPending && capacity?.currentCount && capacity?.maxCount) {
-			trackPageView("view_page", {
+		if (!isPending && capacity) {
+			trackViewPage({
 				page_id: PAGE_ID,
 				submit_progress: Math.round(
 					(capacity.currentCount / capacity.maxCount) * 100,
 				),
 			});
 		}
-	}, [isPending, capacity?.currentCount, capacity?.maxCount]);
+	}, [capacity, isPending]);
 
 	return (
 		<Layout.Root>

app/gathering/[accessKey]/opinion/pending/PendingViewContainer.tsx

@@ -3,7 +3,7 @@
 import { useEffect } from "react";
 import { useParams, redirect } from "next/navigation";
 
-import { trackPageView, trackShareClick } from "#/components/analytics";
+import { trackViewPage, trackShareClick } from "#/components/analytics";
 import { Button } from "#/components/button";
 import { Layout } from "#/components/layout";
 import {
@@ -38,17 +38,17 @@ export function PendingViewContainer() {
 	};
 
 	useEffect(() => {
-		if (!isComplete && capacity?.currentCount && capacity?.maxCount) {
+		if (!isComplete && capacity) {
 			const progress = Math.round(
 				(capacity.currentCount / capacity.maxCount) * 100,
 			);
 
-			trackPageView("view_page", {
+			trackViewPage({
 				page_id: PAGE_ID,
 				submit_progress: progress,
 			});
 		}
-	}, [isComplete, capacity?.currentCount, capacity?.maxCount]);
+	}, [capacity, isComplete]);
 
 	return (
 		<Layout.Root>

app/gathering/[accessKey]/opinion/result/ResultViewContainer.tsx

@@ -3,7 +3,7 @@
 import { useEffect } from "react";
 import { useParams, redirect } from "next/navigation";
 
-import { trackPageView, trackShareClick } from "#/components/analytics";
+import { trackViewPage, trackShareClick } from "#/components/analytics";
 import { Layout } from "#/components/layout";
 import { ShareButton } from "#/components/shareButton";
 import { ResultView } from "#/pageComponents/gathering/opinion";
@@ -35,7 +35,7 @@ export function ResultViewContainer() {
 
 	useEffect(() => {
 		if (isComplete && recommendationResult && accessKey) {
-			trackPageView("view_page", {
+			trackViewPage({
 				page_id: PAGE_ID,
 				group_id: accessKey,
 			});

app/gathering/create/complete/[accessKey]/page.tsx

@@ -5,7 +5,7 @@ import { useEffect } from "react";
 
 import { twJoin } from "tailwind-merge";
 
-import { trackCtaClick, trackPageView } from "#/components/analytics";
+import { trackCtaClick, trackViewPage } from "#/components/analytics";
 import { Layout } from "#/components/layout";
 import { Button } from "#/components/button";
 import { MeetingCompleteIllustration } from "#/components/illustrations";
@@ -30,7 +30,7 @@ export default function GatheringCreateCompletePage() {
 	useEffect(() => {
 		if (!params.accessKey) return;
 
-		trackPageView("view_page", {
+		trackViewPage({
 			page_id: PAGE_ID,
 			group_id: params.accessKey,
 		});

src/components/analytics/events.ts

@@ -40,14 +40,13 @@ export const trackEvent = (
  * 페이지 진입 이벤트
  *
  * @example
- * trackPageView("view_onboarding", { page_id: "onboarding" });
- * trackPageView("view_complete", { page_id: "create_complete", group_id: "abc123" });
+ * trackViewPage({ page_id: "onboarding" });
+ * trackViewPage({ page_id: "create_complete", group_id: "abc123" });
  */
-export const trackPageView = (
-	eventName: string,
+export const trackViewPage = (
 	params: { page_id: string } & Record<string, string | number | boolean>,
 ) => {
-	trackEvent(eventName, params);
+	trackEvent("view_page", params);
 };
 
 /**

src/components/analytics/index.ts

@@ -1,7 +1,7 @@
 export { Analytics } from "./Analytics";
 export {
 	trackEvent,
-	trackPageView,
+	trackViewPage,
 	trackCtaClick,
 	trackStepComplete,
 	trackShareClick,

src/pageComponents/gathering/opinion/LandingView.tsx

@@ -3,7 +3,7 @@
 import { redirect, useParams, useRouter } from "next/navigation";
 import { useEffect } from "react";
 
-import { trackCtaClick, trackPageView } from "#/components/analytics";
+import { trackCtaClick, trackViewPage } from "#/components/analytics";
 import { IntroStep } from "#/pageComponents/gathering/opinion";
 import { Button } from "#/components/button";
 import { Layout } from "#/components/layout";
@@ -33,13 +33,13 @@ export function LandingView() {
 	};
 
 	useEffect(() => {
-		if (!isComplete && gathering?.accessKey) {
-			trackPageView("view_page", {
+		if (!isComplete && gathering) {
+			trackViewPage({
 				page_id: PAGE_ID,
 				group_id: gathering.accessKey,
 			});
 		}
-	}, [isComplete, gathering?.accessKey]);
+	}, [isComplete, gathering]);
 
 	return (
 		<>

src/pageComponents/landing/LandingPage.tsx

@@ -5,7 +5,7 @@ import { useRouter } from "next/navigation";
 import { useEffect } from "react";
 import { motion } from "motion/react";
 
-import { trackCtaClick, trackPageView } from "#/components/analytics";
+import { trackCtaClick, trackViewPage } from "#/components/analytics";
 import { Layout } from "#/components/layout";
 
 const PAGE_ID = "모임생성_랜딩";
@@ -19,7 +19,7 @@ export const LandingPage = () => {
 	};
 
 	useEffect(() => {
-		trackPageView("view_page", { page_id: PAGE_ID });
+		trackViewPage({ page_id: PAGE_ID });
 	}, []);
 
 	return (