Estimate Gas fix (#10559)

* Estimate Gas fix

* format

* format

* test fix

* Update src/Nethermind/Nethermind.Blockchain.Test/TransactionProcessorTests.cs

* Update src/Nethermind/Nethermind.Evm.Test/Tracing/GasEstimationTests.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix shared method

---------

Co-authored-by: Ahmad Bitar <33181301+smartprogrammer93@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

src/Nethermind/Nethermind.Blockchain.Test/TransactionProcessorTests.cs

@@ -466,40 +466,27 @@ public void Can_estimate_with_destroy_refund_and_below_intrinsic_pre_berlin()
         tracer.CalculateAdditionalGasRequired(tx, releaseSpec).Should().Be(24080);
         tracer.GasSpent.Should().Be(35228L);
         long estimate = estimator.Estimate(tx, block.Header, tracer, out string? err, 0);
-        estimate.Should().Be(59307);
+        estimate.Should().Be(54225);
         Assert.That(err, Is.Null);
 
         ConfirmEnoughEstimate(tx, block, estimate);
     }
 
     private void ConfirmEnoughEstimate(Transaction tx, Block block, long estimate)
     {
-        CallOutputTracer outputTracer = new();
-        tx.GasLimit = estimate;
-        TestContext.Out.WriteLine(tx.GasLimit);
-
-        GethLikeTxMemoryTracer gethTracer = new(tx, GethTraceOptions.Default);
         var blkCtx = new BlockExecutionContext(block.Header, _specProvider.GetSpec(block.Header));
-        _transactionProcessor.CallAndRestore(tx, blkCtx, gethTracer);
-        string traceEnoughGas = new EthereumJsonSerializer().Serialize(gethTracer.BuildResult(), true);
 
+        CallOutputTracer outputTracer = new();
+        tx.GasLimit = estimate;
         _transactionProcessor.CallAndRestore(tx, blkCtx, outputTracer);
-        traceEnoughGas.Should().NotContain("OutOfGas");
+        outputTracer.StatusCode.Should().Be(StatusCode.Success,
+            $"transaction should succeed at the estimate ({estimate})");
 
         outputTracer = new CallOutputTracer();
         tx.GasLimit = Math.Min(estimate - 1, estimate * 63 / 64);
-        TestContext.Out.WriteLine(tx.GasLimit);
-
-        gethTracer = new GethLikeTxMemoryTracer(tx, GethTraceOptions.Default);
-        _transactionProcessor.CallAndRestore(tx, blkCtx, gethTracer);
-
-        string traceOutOfGas = new EthereumJsonSerializer().Serialize(gethTracer.BuildResult(), true);
-        TestContext.Out.WriteLine(traceOutOfGas);
-
         _transactionProcessor.CallAndRestore(tx, blkCtx, outputTracer);
-
-        bool failed = traceEnoughGas.Contains("failed") || traceEnoughGas.Contains("OutOfGas");
-        failed.Should().BeTrue();
+        outputTracer.StatusCode.Should().Be(StatusCode.Failure,
+            $"transaction should fail below the estimate ({tx.GasLimit})");
     }
 
     [TestCase]

src/Nethermind/Nethermind.Blockchain/Tracing/EstimateGasTracer.cs

@@ -149,11 +149,14 @@ public void ReportActionError(EvmExceptionType exceptionType, long gasLeft)
 
     public override void ReportOperationError(EvmExceptionType error)
     {
-        OutOfGas |= error == EvmExceptionType.OutOfGas;
-
-        if (error == EvmExceptionType.Revert && _currentNestingLevel == 0)
+        if (_currentNestingLevel == 0)
         {
-            TopLevelRevert = true;
+            OutOfGas |= error == EvmExceptionType.OutOfGas;
+
+            if (error == EvmExceptionType.Revert)
+            {
+                TopLevelRevert = true;
+            }
         }
     }