Skip to content

Commit 3ebd066

Browse files
committed
fix: Build and link to v8_heap_base and v8_heap_base_headers
Not sure if this affects anything but those two static libraries are checked in to the branch, so we should probably be linking to them.
1 parent 241bba4 commit 3ebd066

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

build_v8_source.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -e
44
pushd v8
55

66
ARCH_ARR=(x64-simulator arm64-simulator arm64-device)
7-
MODULES=(v8_base_without_compiler v8_compiler v8_libplatform v8_libbase v8_bigint v8_snapshot torque_generated_initializers torque_generated_definitions)
7+
MODULES=(v8_base_without_compiler v8_compiler v8_libplatform v8_libbase v8_bigint v8_snapshot v8_heap_base v8_heap_base_headers torque_generated_initializers torque_generated_definitions)
88

99
for CURRENT_ARCH in ${ARCH_ARR[@]}
1010
do

v8ios.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2670,6 +2670,7 @@
26702670
"-ltorque_generated_initializers",
26712671
"-ltorque_generated_definitions",
26722672
"-lv8_heap_base",
2673+
"-lv8_heap_base_headers",
26732674
"-linspector_protocol",
26742675
"-linspector",
26752676
"-linspector_string_conversions",
@@ -2748,6 +2749,7 @@
27482749
"-ltorque_generated_initializers",
27492750
"-ltorque_generated_definitions",
27502751
"-lv8_heap_base",
2752+
"-lv8_heap_base_headers",
27512753
"-linspector_protocol",
27522754
"-linspector",
27532755
"-linspector_string_conversions",

0 commit comments

Comments
 (0)