Skip to content

Commit f82c24e

Browse files
authored
fix(chart): Use image tags instead of digest for multi-registry support (#122)
1 parent 48cc4ff commit f82c24e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

chart/templates/deployment.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ kind: Deployment
33
metadata:
44
name: {{ include "chart.fullname" . }}-controller-manager
55
namespace: "{{ .Release.Namespace }}"
6+
annotations:
7+
checkov.io/skip1: CKV_K8S_43=Image digest not required - we use tags
68
labels:
79
app: {{ include "chart.fullname" . }}-controller-manager
810
app.kubernetes.io/component: manager
@@ -93,7 +95,7 @@ spec:
9395
- name: KUBERNETES_CLUSTER_DOMAIN
9496
value: {{ quote .Values.kubernetesClusterDomain }}
9597
image: {{ .Values.controllerManager.manager.image.repository }}{{- if .Values.controllerManager.manager.image.digest }}{{- if .Values.controllerManager.manager.image.tag }}:{{ .Values.controllerManager.manager.image.tag }}@{{ .Values.controllerManager.manager.image.digest }}{{- else }}@{{ .Values.controllerManager.manager.image.digest }}{{- end }}{{- else }}:{{ .Values.controllerManager.manager.image.tag | default .Chart.AppVersion }}{{- end }}
96-
imagePullPolicy: IfNotPresent
98+
imagePullPolicy: Always
9799
livenessProbe:
98100
httpGet:
99101
path: /healthz

chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ controllerManager:
8585
image:
8686
repository: nvcr.io/nvidia/skyhook/operator
8787
tag: "" ## if both tag and digest are omitted, defaults to the chart appVersion
88-
digest: "sha256:b3acae2320d9d768fff455f5986fea9084b099291ecdd258d1580180dabc4efe" # manifest list digest (multi-arch)
88+
digest: "" # manifest list digest (multi-arch)
8989
## agentImage: is the image used for the agent container. This image is the default for this install, but can be overridden in the CR at package level.
9090
agent:
9191
repository: nvcr.io/nvidia/skyhook/agent

0 commit comments

Comments
 (0)