Skip to content
This repository was archived by the owner on Jan 22, 2024. It is now read-only.

Commit 1269921

Browse files
author
Renaud Gaubert
committed
Update nvidia-docker to use new runtime
1 parent cd0f1e3 commit 1269921

File tree

8 files changed

+44
-530
lines changed

8 files changed

+44
-530
lines changed

Dockerfile.amzn

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ RUN yum install -y \
99
# packaging
1010
ARG PKG_VERS
1111
ARG PKG_REV
12-
ARG RUNTIME_VERSION
1312
ARG DOCKER_VERSION
1413

1514
ENV VERSION $PKG_VERS
1615
ENV RELEASE $PKG_REV
17-
ENV RUNTIME_VERSION $RUNTIME_VERSION
1816
ENV DOCKER_VERSION $DOCKER_VERSION
1917

2018
# output directory
@@ -31,7 +29,6 @@ CMD rpmbuild --clean -bb \
3129
-D "_topdir $PWD" \
3230
-D "version $VERSION" \
3331
-D "release $RELEASE" \
34-
-D "runtime_version $RUNTIME_VERSION" \
3532
-D "docker_version $DOCKER_VERSION" \
3633
SPECS/nvidia-docker2.spec && \
3734
mv RPMS/noarch/*.rpm /dist

Dockerfile.centos

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ RUN yum install -y \
99
# packaging
1010
ARG PKG_VERS
1111
ARG PKG_REV
12-
ARG RUNTIME_VERSION
1312
ARG DOCKER_VERSION
1413

1514
ENV VERSION $PKG_VERS
1615
ENV RELEASE $PKG_REV
17-
ENV RUNTIME_VERSION $RUNTIME_VERSION
1816
ENV DOCKER_VERSION $DOCKER_VERSION
1917

2018
# output directory
@@ -31,7 +29,6 @@ CMD rpmbuild --clean -bb \
3129
-D "_topdir $PWD" \
3230
-D "version $VERSION" \
3331
-D "release $RELEASE" \
34-
-D "runtime_version $RUNTIME_VERSION" \
3532
-D "docker_version $DOCKER_VERSION" \
3633
SPECS/nvidia-docker2.spec && \
3734
mv RPMS/noarch/*.rpm /dist

Dockerfile.debian

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ ARG DOCKER_VERSION
1818
ENV DEBFULLNAME "NVIDIA CORPORATION"
1919
ENV DEBEMAIL "[email protected]"
2020
ENV REVISION "$PKG_VERS-$PKG_REV"
21-
ENV RUNTIME_VERSION $RUNTIME_VERSION
2221
ENV DOCKER_VERSION $DOCKER_VERSION
2322
ENV SECTION ""
2423

@@ -33,7 +32,7 @@ COPY daemon.json $DIST_DIR/daemon.json
3332
WORKDIR $DIST_DIR
3433
COPY debian ./debian
3534

36-
RUN sed -i "s;@VERSION@;${REVISION#*+};" debian/changelog && \
35+
RUN sed -i "s;@VERSION@;${REVISION};" debian/changelog && \
3736
if [ "$REVISION" != "$(dpkg-parsechangelog --show-field=Version)" ]; then exit 1; fi
3837

3938
CMD export DISTRIB="unstable" && \

Dockerfile.ubuntu

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ ARG DOCKER_VERSION
1919
ENV DEBFULLNAME "NVIDIA CORPORATION"
2020
ENV DEBEMAIL "[email protected]"
2121
ENV REVISION "$PKG_VERS-$PKG_REV"
22-
ENV RUNTIME_VERSION $RUNTIME_VERSION
2322
ENV DOCKER_VERSION $DOCKER_VERSION
2423
ENV SECTION ""
2524

@@ -35,8 +34,8 @@ WORKDIR $DIST_DIR
3534
COPY debian ./debian
3635

3736

38-
RUN sed -i "s;@VERSION@;${REVISION#*+};" debian/changelog && \
39-
if [ "$REVISION" != "$(dpkg-parsechangelog --show-field=Version)" ]; then exit 1; fi
37+
RUN sed -i "s;@VERSION@;${REVISION};" debian/changelog && \
38+
if [ "$REVISION" != "$(dpkg-parsechangelog --show-field=Version)" ]; then echo "$(dpkg-parsechangelog --show-field=Version)" && exit 1; fi
4039

4140
CMD export DISTRIB="$(lsb_release -cs)" && \
4241
debuild --preserve-env --dpkg-buildpackage-hook='sh debian/prepare' -i -us -uc -b && \

Makefile

Lines changed: 38 additions & 516 deletions
Large diffs are not rendered by default.

debian/changelog

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
nvidia-docker2 (2.0.3+@VERSION@) UNRELEASED; urgency=medium
1+
nvidia-docker2 (@VERSION@) UNRELEASED; urgency=medium
22

33
* 2e9f20b Improve pass-through of docker arguments
44
* 4edca2f Pave the way for a hypothetical transitional package from v1

debian/control

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Package: nvidia-docker2
1212
Architecture: all
1313
Breaks: nvidia-docker (<< 2.0.0)
1414
Replaces: nvidia-docker (<< 2.0.0)
15-
Depends: ${misc:Depends}, nvidia-container-runtime (= @RUNTIME_VERSION@), @DOCKER_VERSION@
15+
Depends: ${misc:Depends}, nvidia-container-runtime (>= 3.0.0), @DOCKER_VERSION@
1616
Description: nvidia-docker CLI wrapper
1717
Replaces nvidia-docker with a new implementation based on
1818
nvidia-container-runtime

rpm/SPECS/nvidia-docker2.spec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Source1: daemon.json
1616
Source2: LICENSE
1717

1818
Conflicts: nvidia-docker < 2.0.0
19-
Requires: nvidia-container-runtime = %{runtime_version}
19+
Requires: nvidia-container-runtime >= 3.0.0
2020
Requires: %{docker_version}
2121

2222
%description

0 commit comments

Comments
 (0)