Skip to content

Commit 9ebc3ab

Browse files
authored
[nvbugs/5385972][nvbugs/5387423][Fix] Minor fix for llava_next/llava_onevision (#5998)
Signed-off-by: Mina Huai <[email protected]>
1 parent ab1c547 commit 9ebc3ab

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

tensorrt_llm/runtime/multimodal_model_runner.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2647,7 +2647,7 @@ def setup_inputs(self, input_text, raw_image, raw_audio=None):
26472647
)
26482648
image = None
26492649
elif self.model_type in ['llava_onevision']:
2650-
pre_prompt = "<|im_start|>user "
2650+
pre_prompt = "<|im_start|>user " + "<video>" if self.args.video_path is not None else "<image>"
26512651
if input_text is None:
26522652
input_text = "Question: which city is this? Answer:" if self.args.video_path is None else "Why is this video funny?"
26532653
post_prompt = f"\n{input_text}<|im_end|><|im_start|>assistant\n"
@@ -2658,7 +2658,7 @@ def setup_inputs(self, input_text, raw_image, raw_audio=None):
26582658
text=prompt,
26592659
return_tensors="pt")
26602660
else:
2661-
image = self.processor(videos=raw_image,
2661+
image = self.processor(videos=list(raw_image),
26622662
text=prompt,
26632663
return_tensors="pt")
26642664

tensorrt_llm/tools/multimodal_builder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,12 +596,12 @@ def forward(self, pixel_values):
596596
args.output_dir,
597597
args.max_batch_size)
598598
if args.model_type == "llava_next":
599-
image_newline = model.image_newline.data
599+
image_newline = model.model.image_newline.data
600600
tensor_img_newline = {"image_newline": image_newline}
601601
save_file(tensor_img_newline,
602602
os.path.join(args.output_dir, "image_newlines.safetensors"))
603603
if args.model_type == "llava_onevision":
604-
image_newline = model.image_newline.data
604+
image_newline = model.model.image_newline.data
605605
tensor_img_newline = {"image_newline": image_newline}
606606
save_file(tensor_img_newline,
607607
os.path.join(args.output_dir, "image_newlines.safetensors"))

tests/integration/test_lists/waives.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -432,15 +432,11 @@ examples/test_multimodal.py::test_llm_multimodal_general[VILA1.5-3b-pp:1-tp:1-fl
432432
accuracy/test_llm_api_pytorch.py::TestNemotronNas::test_auto_dtype_tp8 SKIP (https://nvbugs/5380101)
433433
test_e2e.py::test_ptp_quickstart_advanced_8gpus[Llama3.1-405B-FP8-llama-3.1-model/Llama-3.1-405B-Instruct-FP8] SKIP (https://nvbugs/5380570)
434434
test_e2e.py::test_ptp_quickstart_advanced_8gpus[Nemotron-Ultra-253B-nemotron-nas/Llama-3_1-Nemotron-Ultra-253B-v1] SKIP (https://nvbugs/5380570)
435-
triton_server/test_triton.py::test_llava_onevision[llava_onevision] SKIP (https://nvbugs/5385972)
436435
examples/test_multimodal.py::test_llm_multimodal_general[Qwen2-VL-7B-Instruct-pp:1-tp:1-float16-bs:1-cpp_e2e:False-nb:4] SKIP (https://nvbugs/5385981)
437-
examples/test_multimodal.py::test_llm_multimodal_general[llava-v1.6-mistral-7b-hf-pp:1-tp:1-float16-bs:1-cpp_e2e:False-nb:1] SKIP (https://nvbugs/5385972)
438436
examples/test_multimodal.py::test_llm_fp8_multimodal_general[fp8-fp8-cnn_dailymail-Qwen2-VL-7B-Instruct-pp:1-tp:1-bfloat16-bs:1-cpp_e2e:False] SKIP (https://nvbugs/5385987)
439437
examples/test_multimodal.py::test_llm_multimodal_general[Phi-4-multimodal-instruct-pp:1-tp:1-float16-bs:1-cpp_e2e:False-nb:1] SKIP (https://nvbugs/5385992)
440438
accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_nvfp4_multi_gpus[throughput_tp8] SKIP (https://nvbugs/5377914)
441439
test_e2e.py::test_ptp_scaffolding[DeepSeek-R1-Distill-Qwen-7B-DeepSeek-R1/DeepSeek-R1-Distill-Qwen-7B] SKIP (https://nvbugs/5387375)
442-
examples/test_multimodal.py::test_llm_multimodal_general[llava-onevision-qwen2-7b-ov-hf-video-pp:1-tp:1-float16-bs:1-cpp_e2e:False-nb:1] SKIP (https://nvbugs/5387423)
443-
examples/test_multimodal.py::test_llm_multimodal_general[llava-onevision-qwen2-7b-ov-hf-pp:1-tp:1-float16-bs:1-cpp_e2e:False-nb:1] SKIP (https://nvbugs/5387423)
444440
examples/test_multimodal.py::test_llm_multimodal_general[kosmos-2-pp:1-tp:1-float16-bs:1-cpp_e2e:False-nb:1] SKIP (https://nvbugs/5387422)
445441
examples/test_multimodal.py::test_llm_multimodal_general[fuyu-8b-pp:1-tp:1-float16-bs:1-cpp_e2e:False-nb:1] SKIP (https://nvbugs/5387424)
446442
test_e2e.py::test_ptp_quickstart SKIP (https://nvbugs/5387762)

0 commit comments

Comments
 (0)