Skip to content

Commit dc5a99a

Browse files
committed
finalize
Signed-off-by: Oliver Koenig <[email protected]>
1 parent edad87b commit dc5a99a

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

.github/workflows/_release_library.yml

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,9 @@ on:
6262
SLACK_RELEASE_ENDPOINT:
6363
required: true
6464

65-
env:
66-
PROJECT_NAME: ${{ inputs.library-name }}
67-
VERSION: ${{ needs.build-test-publish-wheel.outputs.version }}
68-
6965
jobs:
7066
build-test-publish-wheel:
71-
uses: NIVIDA/NeMo-FW-CI-templates/.github/workflows/_build_test_publish_wheel.yml@v0.8.0
67+
uses: NVIDIA/NeMo-FW-CI-templates/.github/workflows/_build_test_publish_wheel.yml@v0.9.2
7268
with:
7369
dry-run: false
7470
build-ref: ${{ inputs.release-ref }}
@@ -91,6 +87,8 @@ jobs:
9187
name: main
9288
env:
9389
REPOSITORY: ${{ github.repository }}
90+
PROJECT_NAME: ${{ inputs.library-name }}
91+
VERSION: ${{ needs.build-test-publish-wheel.outputs.version }}
9492
steps:
9593
- name: Checkout repository
9694
uses: actions/checkout@v4
@@ -141,11 +139,13 @@ jobs:
141139
notify:
142140
needs: [build-test-publish-wheel, create-gh-release]
143141
runs-on: ubuntu-latest
144-
environment: main
142+
# environment: main
145143
env:
146-
GH_URL: https://github.com/${{ github.repository }}/releases/tag/v${{ needs.build-test-publish-wheel.outputs.version-number }}
147-
PYPI_URL: https://pypi.org/project/${{ needs.build-test-publish-wheel.outputs.pypi-name }}/${{ needs.build-test-publish-wheel.outputs.version-number }}/
144+
GH_URL: https://github.com/${{ github.repository }}/releases/tag/v${{ needs.build-test-publish-wheel.outputs.version }}
145+
PYPI_URL: https://pypi.org/project/${{ needs.build-test-publish-wheel.outputs.pypi-name }}/${{ needs.build-test-publish-wheel.outputs.version }}/
148146
SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASE_ENDPOINT }}
147+
PROJECT_NAME: ${{ inputs.library-name }}
148+
VERSION: ${{ needs.build-test-publish-wheel.outputs.version }}
149149
steps:
150150
- name: Checkout
151151
uses: actions/checkout@v4
@@ -156,10 +156,13 @@ jobs:
156156

157157
- name: Send Slack alert
158158
uses: ./send-slack-alert/.github/actions/send-slack-alert
159-
with:
160-
message: >
161-
We have released `${{ env.PROJECT_NAME }}` 🚀✨🎉
159+
env:
160+
MESSAGE: |
161+
We have released `${{ env.VERSION }}` of `${{ env.PROJECT_NAME }}` 🚀✨🎉
162162
163-
* <${{ env.GH_URL }}|GitHub release>
164-
* <${{ env.PYPI_URL }}|PyPi release>
163+
• <${{ env.GH_URL }}|GitHub release>
164+
• <${{ env.PYPI_URL }}|PyPi release>
165+
166+
with:
167+
message: ${{ env.MESSAGE }}
165168
webhook: ${{ env.SLACK_WEBHOOK }}

0 commit comments

Comments
 (0)