Remove nginx reloader, since memory leak seems fixed.

I'm not exactly sure what fixed it, but I think between removing some of
the third party nginx modules, and removing global variables and
pre-loading all the lua modules, the memory growth seems to be fixed, so
we no longer need to periodically reload nginx.

Author: GUI

bin/api-umbrella-nginx-reloader

@@ -244,7 +244,6 @@ def install_package(version)
       "mongod",
       "mora",
       "nginx",
-      "nginx-reloader",
       "rsyslog",
       "trafficserver",
       "web-delayed-job",
@@ -263,7 +262,6 @@ def install_package(version)
       "/opt/api-umbrella/var/log/geoip-auto-updater/current",
       "/opt/api-umbrella/var/log/mongod/current",
       "/opt/api-umbrella/var/log/mora/current",
-      "/opt/api-umbrella/var/log/nginx-reloader/current",
       "/opt/api-umbrella/var/log/nginx/current",
       "/opt/api-umbrella/var/log/perpd/current",
       "/opt/api-umbrella/var/log/rsyslog/current",

build/package/verify/spec/localhost/service_spec.rb

@@ -50,7 +50,6 @@ nginx:
       size: 20m
     upstream_checksums:
       size: 200k
-  _reloader_frequency: 14400 # 4 hours
 gatekeeper:
   api_key_methods:
     - header

config/default.yml

@@ -407,7 +407,6 @@ local function set_computed_config()
     ["_service_router_enabled?"] = array_includes(config["services"], "router"),
     ["_service_auto_ssl_enabled?"] = array_includes(config["services"], "auto_ssl"),
     ["_service_web_enabled?"] = array_includes(config["services"], "web"),
-    ["_service_nginx_reloader_enabled?"] = (array_includes(config["services"], "router") and config["nginx"]["_reloader_frequency"]),
     router = {
       trusted_proxies = trusted_proxies,
     },

src/api-umbrella/cli/read_config.lua

@@ -54,14 +54,6 @@ local function reload_dev_env_ember_server(perp_base)
   end
 end
 
-local function reload_nginx_reloader(perp_base)
-  local _, _, err = run_command({ "perpctl", "-b", perp_base, "term", "nginx-reloader" })
-  if err then
-    print("Failed to reload nginx-reloader\n" .. err)
-    os.exit(1)
-  end
-end
-
 return function(options)
   options["reload"] = nil
 
@@ -84,10 +76,6 @@ return function(options)
   if config["_service_router_enabled?"] and (is_empty(options) or options["router"]) then
     reload_trafficserver(config)
     reload_nginx(perp_base)
-
-    if config["_service_nginx_reloader_enabled?"] then
-      reload_nginx_reloader(perp_base)
-    end
   end
 
   if config["app_env"] == "development" then

src/api-umbrella/cli/reload.lua

@@ -267,7 +267,6 @@ local function activate_services()
     active_services["geoip-auto-updater"] = 1
     active_services["mora"] = 1
     active_services["nginx"] = 1
-    active_services["nginx-reloader"] = 1
     active_services["rsyslog"] = 1
     active_services["trafficserver"] = 1
   end