[Bug] beats_metricbeat_package newline character issue

[cbeaujoin-stellar]

Please try to fill out as much of the information below as you can. Thank you!

Yes, I've searched similar issues on GitHub and didn't find any.

Which version contains the bug?
Current

Describe the bug

ansible-collection-elasticstack/roles/beats/tasks/metricbeat.yml

Line 5 in 87a7dc6

beats_metricbeat_package: >

beats_metricbeat_package is being constructed with a newline character at the end (\n), which is causing a JSON parsing error. in the Install Metricbeat - * tasks.

This is happening because of the > YAML folded scalar operator used in the set_fact task.

We can manage it with the YAML scalar operator by using >- instead of >.
The minus sign tells YAML to strip the trailing newline.

- name: Construct exact name of Metricbeat package
  ansible.builtin.set_fact:
    beats_metricbeat_package: >-
      {{
      'metricbeat' +
      (elasticstack_versionseparator +
      elasticstack_version |
      string if elasticstack_version is defined else '') |
      replace(' ', '')
      }}

How to recreate the bug?

ansible_os_family == "Debian"
ansible_distribution_major_version: '12'
elasticstack_release: 7
elasticstack_version: 7.17.23
elasticstack_variant: 'oss'

[widhalmt]

Great find! I'll look into it and I'll see if there's something similar elsewhere in the code. Then I'll try to provide a fix.

[widhalmt]

I can't reproduce the error. Ok, I tried it with Ubuntu 24.04 but Metricbeat installed without problems with the options you've given.

Because it's a simple fix, I'll provide a PR but we have to test a bit more before we can merge it.

[cbeaujoin-stellar]

Hello,

I'm using:

• ansible [core 2.16.3]
• python version = 3.12.3
• jinja version = 3.1.2
• libyaml = True

[DillonWard]

Hello,

I've noticed the same issue and the proposed solution works. Can we get this resolved?

[widhalmt]

Hi,

Sorry everyone for taking so long for such a small fix.

I scheduled it for merging as soon as the review is in (which should not take longer than tomorrow)