Fix #135: net worth historical chart values appears too low.

Implement bar chart column mouse click to pivot networth report.

Author: clovett

Source/WPF/MoneyPackage/Package.appxmanifest

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Package xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" IgnorableNamespaces="uap rescap">
-  <Identity Name="43906ChrisLovett.MyMoney.Net" Publisher="CN=Chris Lovett, O=Chris Lovett, S=Washington, C=US" Version="2.1.0.41" />
+  <Identity Name="43906ChrisLovett.MyMoney.Net" Publisher="CN=Chris Lovett, O=Chris Lovett, S=Washington, C=US" Version="2.1.0.42" />
   <Properties>
     <DisplayName>MyMoney.Net</DisplayName>
     <PublisherDisplayName>Chris Lovett</PublisherDisplayName>

Source/WPF/MyMoney/Properties/PublishProfiles/ClickOnceProfile.pubxml

@@ -4,8 +4,8 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
 -->
 <Project>
   <PropertyGroup>
-    <ApplicationRevision>41</ApplicationRevision>
-    <ApplicationVersion>2.1.0.41</ApplicationVersion>
+    <ApplicationRevision>42</ApplicationRevision>
+    <ApplicationVersion>2.1.0.42</ApplicationVersion>
     <BootstrapperEnabled>True</BootstrapperEnabled>
     <Configuration>Release</Configuration>
     <CreateWebPageOnPublish>True</CreateWebPageOnPublish>

Source/WPF/MyMoney/Reports/NetWorthReport.cs

@@ -294,6 +294,7 @@ public override async Task Generate(IReportWriter writer)
                     historicalChart.VerticalAlignment = VerticalAlignment.Top;
                     historicalChart.HorizontalAlignment = HorizontalAlignment.Left;
                     historicalChart.ContextMenu = new ContextMenu();
+                    historicalChart.ColumnClicked += this.OnBarChartColumnClicked;
                     var menuItem = new MenuItem() { Header = "Export..." };
                     menuItem.Click += this.ExportHistoryClick;
                     historicalChart.ContextMenu.Items.Add(menuItem);
@@ -325,6 +326,12 @@ public override async Task Generate(IReportWriter writer)
             }
         }
 
+        private void OnBarChartColumnClicked(object sender, ChartDataValue e)
+        {
+            this.reportDate = (DateTime)e.UserData;
+            this.Regenerate();
+        }
+
         private UIElement GenerateBarChartTips(ChartDataValue value)
         {
             var tip = new StackPanel() { Orientation = Orientation.Vertical };

Source/WPF/MyMoney/Setup/changes.xml

@@ -1,5 +1,9 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <changes>
+  <change version="2.1.0.42" date="1/7/2025">
+    - Fix #135: net worth historical chart values appears too low
+    - Implement bar chart column mouse click to pivot networth report.
+  </change>
   <change version="2.1.0.41" date="1/3/2025">
     - Don't store "N/A" in memo field from OFX downloads.
   </change>

Source/WPF/MyMoney/StockQuotes/StockQuoteCache.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Threading.Tasks;
 using System.Windows.Forms.Design.Behavior;
 using Walkabout.Data;
@@ -172,21 +173,6 @@ internal async Task<StockQuoteIndex> LoadIndexFromHistory(Security s)
             return index;
         }
 
-        /// <summary>
-        /// Use this method to provide stock quote info from Transactions in the case that
-        /// you have a security that has no download stock price history, which can happen
-        /// with custom securities that are not publicly traded.
-        /// </summary>
-        internal void SetQuote(DateTime date, Security security, decimal price)
-        {
-            if (!this.quoteIndex.TryGetValue(security, out StockQuoteIndex index))
-            {
-                // create an empty index that we can update below.
-                this.quoteIndex[security] = new StockQuoteIndex();
-            }
-            this.quoteIndex[security].SetQuote(date, price);
-        }
-
         /// <summary>
         /// Provides optimized access to stock quotes
         /// </summary>

Source/WPF/MyMoney/Views/GraphGenerators.cs

@@ -223,13 +223,6 @@ public async Task Prepare(IStatusService status)
                             case InvestmentType.Add:
                                 if (i.Units > 0)
                                 {
-                                    if (i.UnitPrice != 0)
-                                    {
-                                        // In case we don't have any online stock quote histories this at least
-                                        // tells our StockQuotesByDate what the unit price was on the date of this
-                                        // transaction.
-                                        this.RecordPrice(i.Date, s, i.UnitPrice);
-                                    }
                                     holdings.Buy(i.Security, i.Date, i.Units, i.OriginalCostBasis);
                                     foreach (var sale in holdings.ProcessPendingSales(i.Security))
                                     {
@@ -241,10 +234,6 @@ public async Task Prepare(IStatusService status)
                             case InvestmentType.Sell:
                                 if (i.Units > 0)
                                 {
-                                    if (i.UnitPrice != 0)
-                                    {
-                                        this.RecordPrice(i.Date, s, i.UnitPrice);
-                                    }
                                     if (i.Transaction.Transfer == null)
                                     {
                                         foreach (var sale in holdings.Sell(s, i.Date, i.Units, i.OriginalCostBasis))
@@ -324,14 +313,6 @@ private async Task<decimal> ComputeMarketValue(DateTime date, AccountHoldings ho
             return total;
         }
 
-        private void RecordPrice(DateTime date, Security security, decimal price)
-        {
-            if (security != null && this.cache != null)
-            {
-                this.cache.SetQuote(date, security, price);
-            }
-        }
-
         private void ApplyPendingSplits(DateTime dateTime, AccountHoldings holding)
         {
             // When a stock split becomes due we remove it from the pendingSplits

Source/WPF/Version/Version.cs

@@ -6,5 +6,5 @@
 // And also sync this with the MSIX package manifest in
 // ~\MyMoney.Net\Source\WPF\MoneyPackage\Package.appxmanifest
 
-[assembly: AssemblyVersion("2.1.0.41")]
-[assembly: AssemblyFileVersion("2.1.0.41")]
+[assembly: AssemblyVersion("2.1.0.42")]
+[assembly: AssemblyFileVersion("2.1.0.42")]

Source/WPF/Version/Version.props

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
-    <ApplicationRevision>41</ApplicationRevision>
-    <ApplicationVersion>2.1.0.41</ApplicationVersion>
+    <ApplicationRevision>42</ApplicationRevision>
+    <ApplicationVersion>2.1.0.42</ApplicationVersion>
   </PropertyGroup>
 </Project>

Source/WPF/Version/VersionMaster.txt

@@ -1 +1 @@
-2.1.0.41
+2.1.0.42

docs/Reports/NetworthReport.md

@@ -8,8 +8,11 @@ This report summarizes the current value of all your holdings up to the
 given date and subtracts credit card balances, and any loans to provide a net worth total.
 
 You can pick different dates to get a detailed report for any date that you have historical
-stock quote data for, see [StockQuoteService](../Accounts/StockQuoteServices.md).
+stock quote data for. Simply edit the date field.
+
+Historical stock quotes come from your configured [StockQuoteService](../Accounts/StockQuoteServices.md).
 
 You can also create [Asset](../Accounts/Assets.md) accounts to cover the value of personal property so those show up in the report also.  Just set the Account Type to "Asset" in the Account properties dialog.
 
-The bar chart shows the networth back in time.
+The bar chart shows the networth back in time.  You can click a bar chart column to regenerate the report
+for the date listed in the tooltip for that bar.