Skip to content

Improve setting screen abstractions #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RacoonDog
Copy link
Collaborator

Type of change

  • Bug fix
  • New feature

Description

Changes:

  • Improved BlockDataSetting search bar accuracy
  • Added vanilla enchants to EnchantmentListSetting screen when outside of a world
  • Added support for internal names (identifiers) for searching in list setting types
  • Added support for class names (using the current namespace) for searching in PacketBoolSetting
  • Removed air block from BlockDataSetting

Api Changes:

  • CollectionListSettingScreen and DynamicRegistryListSettingScreen moved into gui.screens.settings.base package
  • Added CollectionListSettingScreen#postWidgets to append widgets to the screen after the default ones
  • CollectionListSettingScreen#skipValue was removed, use CollectionListSettingScreen#includeValue for the same result
  • CollectionListSettingScreen#valueName was removed, use CollectionListSettingScreen#valueNames instead
  • Added CollectionMapSettingScreen, as an abstract setting screen for Map setting types, with BlockDataSettingScreen as a reference implementation

Internal Changes:

  • DynamicRegistryListSettingScreen is now backed by CollectionListSettingScreen
  • CollectionListSettingScreen, DynamicRegistryListSettingScreen, and BlockDataSettingScreen search bar logic abstracted into gui.screens.settings.base.SortingHelper
  • Optimized collection setting sorting algorithm

Related issues

none

How Has This Been Tested?

the J

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant