Improve setting screen abstractions #5580
Open
+454
−379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Changes:
BlockDataSetting
search bar accuracyEnchantmentListSetting
screen when outside of a worldPacketBoolSetting
BlockDataSetting
Api Changes:
CollectionListSettingScreen
andDynamicRegistryListSettingScreen
moved intogui.screens.settings.base
packageCollectionListSettingScreen#postWidgets
to append widgets to the screen after the default onesCollectionListSettingScreen#skipValue
was removed, useCollectionListSettingScreen#includeValue
for the same resultCollectionListSettingScreen#valueName
was removed, useCollectionListSettingScreen#valueNames
insteadCollectionMapSettingScreen
, as an abstract setting screen forMap
setting types, withBlockDataSettingScreen
as a reference implementationInternal Changes:
DynamicRegistryListSettingScreen
is now backed byCollectionListSettingScreen
CollectionListSettingScreen
,DynamicRegistryListSettingScreen
, andBlockDataSettingScreen
search bar logic abstracted intogui.screens.settings.base.SortingHelper
Related issues
none
How Has This Been Tested?
the J
Checklist: