Skip to content

Commit 95c13ef

Browse files
committed
Little tweaks
1 parent 9a4f108 commit 95c13ef

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/release-specification.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ packages:
338338
});
339339
});
340340

341-
it('throws if any of the keys in the "packages" objectproperty do not match the names of any workspace packages', async () => {
341+
it('throws if any of the keys in the "packages" object do not match the names of any workspace packages', async () => {
342342
await withSandbox(async (sandbox) => {
343343
const project = buildMockProject({
344344
workspacePackages: {

src/repo.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ async function getStdoutFromCommandWithin(
2121
* Runs a Git command within the given repository, obtaining the immediate
2222
* output.
2323
*
24-
* @param repositoryDirectoryPath - The directory of the repository.
24+
* @param repositoryDirectoryPath - The path to the repository directory.
2525
* @param args - The arguments to the command.
2626
* @returns The standard output of the command.
2727
* @throws An execa error object if the command fails in some way.
@@ -44,7 +44,7 @@ export async function getStdoutFromGitCommandWithin(
4444
* If the URL of the "origin" remote matches neither pattern, an error is
4545
* thrown.
4646
*
47-
* @param repositoryDirectoryPath - The path to the project directory.
47+
* @param repositoryDirectoryPath - The path to the repository directory.
4848
* @returns The HTTPS URL of the repository, e.g.
4949
* `https://github.com/OrganizationName/RepositoryName`.
5050
*/
@@ -83,30 +83,30 @@ export async function getRepositoryHttpsUrl(
8383
* This function does three things:
8484
*
8585
* 1. Stages all of the changes which have been made to the repo thus far and
86-
* creates a new Git commit which carries the name of the new release.
86+
* creates a new Git commit which carries the name of the new release.
8787
* 2. Creates a new branch pointed to that commit (which also carries the name
88-
* of the new release).
88+
* of the new release).
8989
* 3. Switches to that branch.
9090
*
91-
* @param projectRepositoryPath - The path to the project directory.
91+
* @param repositoryDirectoryPath - The path to the repository directory.
9292
* @param releaseName - The name of the release, which will be used to name the
9393
* commit and the branch.
9494
*/
9595
export async function captureChangesInReleaseBranch(
96-
projectRepositoryPath: string,
96+
repositoryDirectoryPath: string,
9797
releaseName: string,
9898
) {
9999
// TODO: What if the index was dirty before this script was run? Or what if
100100
// you're in the middle of a rebase? Might want to check that up front before
101101
// changes are even made.
102102
// TODO: What if this branch already exists? Append the build number?
103-
await getStdoutFromGitCommandWithin(projectRepositoryPath, [
103+
await getStdoutFromGitCommandWithin(repositoryDirectoryPath, [
104104
'checkout',
105105
'-b',
106106
`release/${releaseName}`,
107107
]);
108-
await getStdoutFromGitCommandWithin(projectRepositoryPath, ['add', '-A']);
109-
await getStdoutFromGitCommandWithin(projectRepositoryPath, [
108+
await getStdoutFromGitCommandWithin(repositoryDirectoryPath, ['add', '-A']);
109+
await getStdoutFromGitCommandWithin(repositoryDirectoryPath, [
110110
'commit',
111111
'-m',
112112
`Release ${releaseName}`,

0 commit comments

Comments
 (0)