Skip to content

Commit 1ff4efc

Browse files
LilyheartLilyheart
committed
Add Error List
1 parent bc4c8ce commit 1ff4efc

File tree

10 files changed

+328
-13
lines changed

10 files changed

+328
-13
lines changed

‎.eslintrc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"gitlabKey": true,
2727
"projectID": true,
2828
"currProjectName": true,
29+
"currProjStartDate": true,
2930
"currUserName": true,
3031
"projectList": true,
3132
"lastUpdate": true,

‎README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ Not current accepting pull requests.
2626

2727
## History
2828

29+
### [[0.2.7]](https://github.com/Lilyheart/agile-gitlabce/releases/tag/v0.2.7) - 2019-12-02
30+
New Burndown Chart type.
31+
2932
### [[0.2.6]](https://github.com/Lilyheart/agile-gitlabce/releases/tag/v0.2.6) - 2019-12-02
3033
New Burndown Chart type.
3134

‎index.html‎

Lines changed: 63 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,11 @@ <h3 class="pad-below">Gitlab Setup</h3>
178178
<a class="nav-link disabled" id="burndown-tab" data-toggle="tab" href="#burndowntab" role="tab" aria-controls="burndowntab"
179179
aria-selected="false" onclick="checkForUpdates()">Burndown</a>
180180
</li>
181+
<li class="nav-item d-none" id="error-tab-item">
182+
<a class="nav-link error" id="errors-tab" data-toggle="tab" href="#errorstab" role="tab" aria-controls="faqtab" aria-selected="true">Errors</a>
183+
</li>
181184
<li class="nav-item">
182-
<a class="nav-link" id="faq-tab" data-toggle="tab" href="#faqtab" role="tab" aria-controls="fawtab"
185+
<a class="nav-link" id="faq-tab" data-toggle="tab" href="#faqtab" role="tab" aria-controls="faqtab"
183186
aria-selected="true">FAQ</a>
184187
</li>
185188
</ul>
@@ -209,6 +212,9 @@ <h3 class="pad-below">Gitlab Setup</h3>
209212
</div>
210213
<div id="burndown" style="display: none">
211214
<div id="milestone-selection" class="milestone-selection form-group row">
215+
<p class="col-sm-12">
216+
<span class="badge badge-primary">Hint</span> Click on three lines on the upper right of the chart to download, print, and view in full screen.
217+
</p>
212218
<label for="milestone-dropdown" class="col-sm-3 col-form-label">Show Milestone:</label>
213219
<div class="col-sm-9">
214220
<select id="milestone-dropdown" class="align-self-center" name="milestone_id" onchange="burndown.updateBurndownData(this.options[this.selectedIndex].value)">
@@ -244,6 +250,62 @@ <h3 class="pad-below">Gitlab Setup</h3>
244250
</p>
245251
</div>
246252
</div>
253+
</div>
254+
<div class="tab-pane fade show active" id="errorstab" role="tabpanel" aria-labelledby="errors-tab">
255+
<p id="error-counts">
256+
There are 0 errors and 0 warnings.
257+
</p>
258+
<p>
259+
<span class="badge badge-primary">Hint</span> Click on the issue title to open the issue on Gitlab.
260+
</p>
261+
262+
<div id="issue_error_section">
263+
<div class="alert alert-primary" role="alert" data-toggle="collapse" data-target="#issue_errors">
264+
<h4 class="d-inline-flex">Errors</h4>
265+
<button type="button" class="h-100">
266+
<span aria-hidden="true" class="align-middle"><i class="fa fa-sort" aria-hidden="true"></i></span>
267+
</button>
268+
</div>
269+
<div id="issue_errors" class="collapse show mb-5">
270+
<p>Types of issues and possible solution ideas.</p>
271+
<ul class="mb-4">
272+
<li><strong>Spent time with no estimate:</strong>
273+
<ul>
274+
<li>Add estimated time</li>
275+
<li>Remove incorrectly added spent time</li>
276+
</ul>
277+
</li>
278+
<li><strong>More spent time than estimated:</strong>
279+
<ul>
280+
<li>Correct estimated time</li>
281+
<li>Remove incorrectly added spent time</li>
282+
</ul>
283+
</li>
284+
</ul>
285+
<table id="issueerrorstable" class="table table-dark table-hover" style="width:100%;"></table>
286+
</div>
287+
</div>
288+
289+
<div id="issue_warning_section" class="mb-3">
290+
<div class="alert alert-primary mt-3" role="alert" data-toggle="collapse" data-target="#issue_warning">
291+
<h4 class="d-inline-flex">Warnings</h4>
292+
<button type="button" class="h-100">
293+
<span aria-hidden="true" class="align-middle"><i class="fa fa-sort" aria-hidden="true"></i></span>
294+
</button>
295+
</div>
296+
<div id="issue_warning" class="collapse show">
297+
<p>Types of issues and possible solution ideas.</p>
298+
<ul class="mb-4">
299+
<li><strong>Missing estimate:</strong> </li>
300+
<ul>
301+
<li>Close the issue</li>
302+
<li>Add an estimate</li>
303+
</ul>
304+
</ul>
305+
<table id="issuewarningstable" class="table table-dark table-hover" style="width:100%;"></table>
306+
</div>
307+
</div>
308+
247309
</div>
248310
<div class="tab-pane fade show active" id="faqtab" role="tabpanel" aria-labelledby="faq-tab">
249311
<div id="faqtab-html">

‎partials/faqtab.html‎

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,24 @@
1111
<h3>New</h3>
1212
<p>
1313
<ul>
14-
<li>2019/12/02 <strong><u><a href="https://github.com/Lilyheart/agile-gitlabce/releases/tag/v0.2.6">v0.2.6</a></u></strong>:
14+
<!-- <li class="new">2019/MM/DD <strong><u><a href="https://github.com/Lilyheart/agile-gitlabce/releases/tag/vX.X.X">vX.X.X</a></u></strong>: XXXXXX <span class="badge badge-primary">New</span></li> -->
15+
<li>2019/12/03 <strong><u><a href="https://github.com/Lilyheart/agile-gitlabce/releases/tag/v0.2.7">v0.2.7</a></u></strong>: <span class="badge badge-primary">New</span>
16+
<ul>
17+
<li class="new">Any issues that might cause problems on the burndown chart now appear on a Errors/Warnings new tab</li>
18+
</ul>
19+
</li>
20+
<li>2019/12/02 <strong><u><a href="https://github.com/Lilyheart/agile-gitlabce/releases/tag/v0.2.6">v0.2.6</a></u></strong>: <span class="badge badge-primary">New</span>
1521
<ul>
1622
<li class="new">New burndown chart style <a href="#" data-toggle="collapse" data-target="#collapse-burndown-types">(See details)</a></li>
1723
<li class="new">If loading from a bookmark, site no longer loads the entire project list by default. This speeds up response for users with many projects</li>
1824
</ul>
1925
<!-- When deleting this section, be sure to remove new tag -->
2026
</li>
21-
<li>2019/11/16 <strong><u><a href="https://github.com/Lilyheart/agile-gitlabce/releases/tag/v0.2.5">v0.2.5</a></u></strong>: You can now bookmark your project after it's been loaded <span class="badge badge-primary">New</span></li>
22-
<li>2019/11/12 <strong><u><a href="https://github.com/Lilyheart/agile-gitlabce/releases/tag/v0.2.4">v0.2.4</a></u></strong>: Add List of future plans to FAQ list <span class="badge badge-primary">New</span></li>
27+
<li>2019/11/16 <strong><u><a href="https://github.com/Lilyheart/agile-gitlabce/releases/tag/v0.2.5">v0.2.5</a></u></strong>:
28+
<ul>
29+
<li>You can now bookmark your project after it's been loaded</li>
30+
</ul>
31+
</li>
2332
</ul>
2433
</p>
2534
<h3>Getting Started</h3>
@@ -192,7 +201,7 @@ <h4>Differences</h4>
192201
<td></td>
193202
</tr>
194203
<tr>
195-
<td scope="row">Begins</td>
204+
<td scope="row">Beginning value</td>
196205
<td>The sum of the last estimated times entered</td>
197206
<td>The sum of the estimated times entered as of the first date on the chart</td>
198207
</tr>
@@ -205,12 +214,12 @@ <h4>Differences</h4>
205214
<td></td>
206215
</tr>
207216
<tr>
208-
<td scope="row">Begins</td>
217+
<td scope="row">Beginning value</td>
209218
<td>The sum of the last estimated times entered minus any spent time on that day</td>
210219
<td>The sum of the estimated times entered as of the first date on the chart minus any spent time on that day</td>
211220
</tr>
212221
<tr>
213-
<td>Changes</td>
222+
<td>How value changes</td>
214223
<td>The previous day's remaining effort minus any spent time on that day</td>
215224
<td>The previous day's remaining effort minus any spent time on that day and plus/minus any changes to estimated times submitted on that day</td>
216225
</tr>
@@ -291,11 +300,11 @@ <h4>Consistent Features</h4>
291300
<td scope="row" colspan=2 class="text-center">Ideal Burndown Line</td>
292301
</tr>
293302
<tr>
294-
<td>Changes</td>
303+
<td>How value changes</td>
295304
<td>Decreases at a constant rate</td>
296305
</tr>
297306
<tr>
298-
<td scope="row">Ends</td>
307+
<td scope="row">How value ends</td>
299308
<td>Zero at the end date of the project (see above) or end date of the sprint if applicable</td>
300309
</tr>
301310

@@ -315,7 +324,7 @@ <h4>Consistent Features</h4>
315324
<td scope="row" colspan=2 class="text-center">Actual Effort Trend Line</td>
316325
</tr>
317326
<tr>
318-
<td>Changes</td>
327+
<td>How value changes</td>
319328
<td>Linear Regression of the Remaining Effort line</td>
320329
</tr>
321330

‎scripts/burndown.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,12 @@ var burndown = (function () {
288288
}
289289
}
290290
tempSpentTimeList.push({date: date, spent: spent, issue: noteableIID, author: note.author.name});
291+
292+
// **************************** CHECK DATE ****************************
293+
294+
if (new Date(date) < currProjStartDate) {
295+
issues.addIssueError(issueListJSON[noteableIID], "Spend prior to project's creation date");
296+
}
291297
}
292298

293299
// If time spent was removed
@@ -499,6 +505,7 @@ var burndown = (function () {
499505
await getIssuesData();
500506
await setMilestoneData();
501507
await parseNotes();
508+
issues.loadErrorTable();
502509
}
503510

504511
async function updateBurndownData() {

0 commit comments

Comments
 (0)