Add max_size mode to CombinedLoader
#16939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
max_sizemode support to CombinedLoader, which works very much likemax_size_cycle, but it returnsNones instead of cycling through exhausted iterables.Discussed in #16917
Also includes added tests for NamedTuples support in CombinedLoader, which seemed to have been missing. Hopefully this does not break to PR does only one thing rule.
Also: First time contributing, yay!
Before submitting
PR review
Reviewer checklist