-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Merge different gpu backends with accelerator='gpu' #13642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8124087
to
9f19717
Compare
9f19717
to
d630a2c
Compare
d630a2c
to
3247b1f
Compare
d5d1b7a
to
d630a2c
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
src/pytorch_lightning/trainer/connectors/accelerator_connector.py
Outdated
Show resolved
Hide resolved
src/pytorch_lightning/trainer/connectors/accelerator_connector.py
Outdated
Show resolved
Hide resolved
src/pytorch_lightning/trainer/connectors/accelerator_connector.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #13642 +/- ##
=========================================
+ Coverage 49% 76% +27%
=========================================
Files 328 327 -1
Lines 25552 25679 +127
=========================================
+ Hits 12470 19538 +7068
+ Misses 13082 6141 -6941 |
@justusschock CI failures look real |
Fixed it. After the changes we did for ddp fork #13405, we should mock the device parser functions instead of |
What does this PR do?
Setting
accelerator='gpu'
does no longer select theGPUAccelerator
(see #13636 ), but will dynamically choose an available GPU backend (currently cuda or mps)Fixes #13102
Does your PR introduce any breaking changes? If yes, please list them.
Yes, together with #13636 this changes
accelerator='gpu'
to dynamically select gpu backendsBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7