Skip to content

Remove support for passing strategy name to plugins #12700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 12, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 10, 2022

What does this PR do?

Part of #12521

Does your PR introduce any breaking changes? If yes, please list them.

Yes. The following is no longer supported:

Trainer(plugins="ddp_spawn")
Trainer(plugins="ddp_find_unused_parameters_false")
Trainer(plugins=DDPStrategy())

Instead, use:

Trainer(strategy="ddp_spawn")
Trainer(strategy="ddp_find_unused_parameters_false")
Trainer(strategy=DDPStrategy())

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @justusschock @awaelchli @rohitgr7 @Borda @kaushikb11 @ninginthecloud

@awaelchli awaelchli added this to the 1.7 milestone Apr 10, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still draft?

@awaelchli
Copy link
Contributor Author

@rohitgr7 waiting to merge the other one first.

Base automatically changed from refactor/accelerator-strategy-input to master April 11, 2022 20:52
@awaelchli awaelchli marked this pull request as ready for review April 11, 2022 21:06
@awaelchli awaelchli requested a review from tchaton as a code owner April 11, 2022 21:06
@mergify mergify bot added the ready PRs ready to be merged label Apr 11, 2022
@carmocca carmocca merged commit 4a48710 into master Apr 12, 2022
@carmocca carmocca deleted the refactor/plugin-strategy-input branch April 12, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor trainer: connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants