-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Use run name for logging with WandbLogger #12604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @tshu-w ! Using the run name makes a lot of sense instead of the project name. |
@manangoel99 Thank you for confirming and link the old PR. Let's ping PL members to make sure this PR is perfected and merged if there is no reply for some time. |
Hi, @tshu-w - Thank you for creating this PR. We appreciate the contribution 🚀 Looks like the tests are failing, mostly because there is Apologies for the delay in the old PR! |
This will bring one change though. The directory structure for checkpoints currently looks like |
@tshu-w though having |
@krshrimali Hi, thank you remind, I update the test file now.
This is as expected, PL default
As mentioned above, the save_dir, name, and version of a PL logger have specific meanings, and I think the wandb name is the concept that just corresponds to the PL logger's name. Therefore, we need to change the behavior of name, rather than defining a new run_name (which could also be an alias for name, but that's beyond this PR). |
QQ what does name in PL signify. What I mean by this is that you could be naming a project or an experiment in the project. |
I'm the new users of wandb, but from the document here https://docs.wandb.ai/ref/python/init, should As for which |
@tshu-w we can make this change but if |
@manangoel99 agree with you, but that's beyond the scope of this PR. |
@tshu-w I think in that case maybe we could close this PR and I can come up with another PR meanwhile to have deprecation warnings now since the behaviour of the arguments will be changing and this could break people's code so we need to raise deprecation warnings. |
It seems to me that the inconsistency between |
May I suggest the following.
This way, we are backward compatible partially, and the directory doesn't get cluttered every time you run a new experiment. |
@manangoel99 @awaelchli suggest make sense to me, what about you? |
Hi, this issue exists in PL 1.5 either, If you meet error in PL 1.6.3. It might be other bug? And if @awaelchli could mention other appropriate reviewers. |
On 1.5.10 the logger would store checkpoints like this:
On 1.6.3 they're all like this now:
Completely messes up the way I track experiments since on the online interface of wandb references version_id and not version_name. Is this a different issue altogether? |
I suspect yes, though I'm not why this happening on your side. This PR just want to change logger structure like this:
|
Yes I pinged the team for one the third review. Sorry about the wait time, things are slow at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
What does this PR do?
Fixes #12157 and #12603: This fix the name property of WandbLogger for #12028.
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃