Fix a bug in the TarjanSCCVisitor regarding the stack ordering #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead of sorting the nodes when their exploration is finished, push them correctly onto the stack when starting their exploration. * Fix a wrong accessor to the node's id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with the automata lib, I came across another bug related to #21.
There are cases, where the sccId is not uniform for a single SCC at the end. Instead, the stack ordering is the most important thing. It is possible that a single SCC is constructed using more than one sccID on the stack. Luckily, it is possible to recreate the stack order in the visitor by sorting the records on the stack by the number attribute.
A new test case affected by this problem is added as part of this PR.