Skip to content

Commit 83fe543

Browse files
author
Val Brodsky
committed
Fix LabelingService classes
1 parent 85ee809 commit 83fe543

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

libs/labelbox/src/labelbox/schema/labeling_service.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55

66
from labelbox.exceptions import LabelboxError, ResourceNotFoundError
77

8-
from labelbox.pydantic_compat import BaseModel, Field
8+
from pydantic import BaseModel, Field
99
from labelbox.utils import _CamelCaseMixin
1010
from labelbox.schema.labeling_service_dashboard import LabelingServiceDashboard
1111
from labelbox.schema.labeling_service_status import LabelingServiceStatus
1212

1313
Cuid = Annotated[str, Field(min_length=25, max_length=25)]
1414

1515

16-
class LabelingService(BaseModel):
16+
class LabelingService(_CamelCaseMixin):
1717
"""
1818
Labeling service for a project. This is a service that can be requested to label data for a project.
1919
"""
@@ -31,9 +31,6 @@ def __init__(self, **kwargs):
3131
raise RuntimeError(
3232
"Please enable experimental in client to use LabelingService")
3333

34-
class Config(_CamelCaseMixin.Config):
35-
...
36-
3734
@classmethod
3835
def start(cls, client, project_id: Cuid) -> 'LabelingService':
3936
"""

libs/labelbox/src/labelbox/schema/labeling_service_dashboard.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from labelbox.exceptions import ResourceNotFoundError
66
from labelbox.pagination import PaginatedCollection
7-
from labelbox.pydantic_compat import BaseModel, root_validator, Field
7+
from pydantic import BaseModel, root_validator, Field
88
from labelbox.schema.search_filters import SearchFilter, build_search_filter
99
from labelbox.utils import _CamelCaseMixin
1010
from .ontology_kind import EditorTaskType
@@ -39,7 +39,7 @@ class LabelingServiceDashboardTags(BaseModel):
3939
type: str
4040

4141

42-
class LabelingServiceDashboard(BaseModel):
42+
class LabelingServiceDashboard(_CamelCaseMixin):
4343
"""
4444
Represent labeling service data for a project
4545
@@ -105,9 +105,6 @@ def service_type(self):
105105

106106
return sentence_case(self.media_type.value)
107107

108-
class Config(_CamelCaseMixin.Config):
109-
...
110-
111108
@classmethod
112109
def get(cls, client, project_id: str) -> 'LabelingServiceDashboard':
113110
"""

libs/labelbox/src/labelbox/schema/search_filters.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from enum import Enum
33
from typing import List, Literal, Union
44

5-
from labelbox.pydantic_compat import BaseModel, validator
5+
from pydantic import BaseModel, field_validator
66
from labelbox.schema.labeling_service_status import LabelingServiceStatus
77
from labelbox.utils import format_iso_datetime
88

@@ -106,7 +106,6 @@ class WorkspaceFilter(BaseSearchFilter):
106106
class TagFilter(BaseSearchFilter):
107107
"""
108108
Filter for project tags
109-
110109
values are tag ids
111110
"""
112111
operation: Literal[OperationType.Tag] = OperationType.Tag
@@ -123,7 +122,7 @@ class ProjectStageFilter(BaseSearchFilter):
123122
operator: IdOperator
124123
values: List[LabelingServiceStatus]
125124

126-
@validator('values', pre=True)
125+
@field_validator('values')
127126
def validate_values(cls, values):
128127
disallowed_values = [LabelingServiceStatus.Missing]
129128
for value in values:

libs/labelbox/tests/data/annotation_types/test_metrics.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ def test_legacy_scalar_metric():
2424
'extra': {},
2525
}],
2626
'extra': {},
27+
'is_benchmark_reference': False
2728
}
2829
assert label.model_dump(exclude_none=True) == expected
2930

@@ -76,6 +77,7 @@ def test_custom_scalar_metric(feature_name, subclass_name, aggregation, value):
7677
'extra': {}
7778
}],
7879
'extra': {},
80+
'is_benchmark_reference': False
7981
}
8082
assert label.model_dump(exclude_none=True) == expected
8183

@@ -123,6 +125,7 @@ def test_custom_confusison_matrix_metric(feature_name, subclass_name,
123125
'extra': {}
124126
}],
125127
'extra': {},
128+
'is_benchmark_reference': False
126129
}
127130
assert label.model_dump(exclude_none=True) == expected
128131

0 commit comments

Comments
 (0)