fix A LOT of compilation warnings

Author: sebmestrallet

CMakeLists.txt

@@ -36,7 +36,6 @@ include_directories(ext/fmt/include) # why needed ?
 # GraphCutOptimization
 add_subdirectory(ext/GraphCutOptimization)
 include_directories(ext/GraphCutOptimization/src) # why needed ?
-set_source_files_properties(ext/GraphCutOptimization/src/GCoptimization.h PROPERTIES COMPILE_OPTIONS "-Wnon-virtual-dtor;-Wunused-parameter")
 
 # nlohmann/json
 add_subdirectory(ext/json)
@@ -57,44 +56,44 @@ add_compile_definitions(WINDOW_SIZE="3840x2160")
 # EXECUTABLES
 #################
 
-add_executable(automatic_polycube ${SRCFILES} app/automatic_polycube)
+add_executable(automatic_polycube ${SRCFILES} app/automatic_polycube.cpp)
 target_link_libraries(automatic_polycube geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(hex_mesh_viewer ${SRCFILES} app/hex_mesh_viewer)
+add_executable(hex_mesh_viewer ${SRCFILES} app/hex_mesh_viewer.cpp)
 target_link_libraries(hex_mesh_viewer geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(labeling_viewer ${SRCFILES} app/labeling_viewer)
+add_executable(labeling_viewer ${SRCFILES} app/labeling_viewer.cpp)
 target_link_libraries(labeling_viewer geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(labeling_painter ${SRCFILES} app/labeling_painter)
+add_executable(labeling_painter ${SRCFILES} app/labeling_painter.cpp)
 target_link_libraries(labeling_painter geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(extract_surface ${SRCFILES} app/extract_surface)
+add_executable(extract_surface ${SRCFILES} app/extract_surface.cpp)
 target_link_libraries(extract_surface geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(volume_labeling ${SRCFILES} app/volume_labeling)
+add_executable(volume_labeling ${SRCFILES} app/volume_labeling.cpp)
 target_link_libraries(volume_labeling geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(naive_labeling ${SRCFILES} app/naive_labeling)
+add_executable(naive_labeling ${SRCFILES} app/naive_labeling.cpp)
 target_link_libraries(naive_labeling geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(graphcut_labeling ${SRCFILES} app/graphcut_labeling)
+add_executable(graphcut_labeling ${SRCFILES} app/graphcut_labeling.cpp)
 target_link_libraries(graphcut_labeling geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(ovm_io ${SRCFILES} app/ovm_io)
+add_executable(ovm_io ${SRCFILES} app/ovm_io.cpp)
 target_link_libraries(ovm_io geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(areas_to_tilt ${SRCFILES} app/areas_to_tilt)
+add_executable(areas_to_tilt ${SRCFILES} app/areas_to_tilt.cpp)
 target_link_libraries(areas_to_tilt geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(mesh_stats ${SRCFILES} app/mesh_stats)
+add_executable(mesh_stats ${SRCFILES} app/mesh_stats.cpp)
 target_link_libraries(mesh_stats geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(labeling_stats ${SRCFILES} app/labeling_stats)
+add_executable(labeling_stats ${SRCFILES} app/labeling_stats.cpp)
 target_link_libraries(labeling_stats geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(halfedge_movements ${SRCFILES} app/halfedge_movements)
+add_executable(halfedge_movements ${SRCFILES} app/halfedge_movements.cpp)
 target_link_libraries(halfedge_movements geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)
 
-add_executable(flip_normals ${SRCFILES} app/flip_normals)
+add_executable(flip_normals ${SRCFILES} app/flip_normals.cpp)
 target_link_libraries(flip_normals geogram geogram_gfx ${GLFW_LIBRARIES} fmt::fmt gco nlohmann_json)

app/graphcut_labeling.cpp

@@ -144,44 +144,44 @@ class GraphCutLabelingApp : public LabelingViewerApp {
 			ImGui::SliderFloat("+X",&new_data_cost_[0],0.0f,new_data_cost_upper_bound_);
 			ImGui::PopStyleColor();
 			ImGui::SameLine();
-			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",selected_chart_data_cost_stats_.min[0],
-														selected_chart_data_cost_stats_.max[0],
-														selected_chart_data_cost_stats_.avg[0]);
+			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",(double) selected_chart_data_cost_stats_.min[0],
+														(double) selected_chart_data_cost_stats_.max[0],
+														(double) selected_chart_data_cost_stats_.avg[0]);
 			ImGui::PushStyleColor(ImGuiCol_Text, labeling_colors_.color_as_ImVec4( (std::size_t) 1)); // change the text color
 			ImGui::SliderFloat("-X",&new_data_cost_[1],0.0f,new_data_cost_upper_bound_);
 			ImGui::PopStyleColor();
 			ImGui::SameLine();
-			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",selected_chart_data_cost_stats_.min[1],
-														selected_chart_data_cost_stats_.max[1],
-														selected_chart_data_cost_stats_.avg[1]);
+			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",(double) selected_chart_data_cost_stats_.min[1],
+														(double) selected_chart_data_cost_stats_.max[1],
+														(double) selected_chart_data_cost_stats_.avg[1]);
 			ImGui::PushStyleColor(ImGuiCol_Text, labeling_colors_.color_as_ImVec4( (std::size_t) 2)); // change the text color
 			ImGui::SliderFloat("+Y",&new_data_cost_[2],0.0f,new_data_cost_upper_bound_);
 			ImGui::PopStyleColor();
 			ImGui::SameLine();
-			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",selected_chart_data_cost_stats_.min[2],
-														selected_chart_data_cost_stats_.max[2],
-														selected_chart_data_cost_stats_.avg[2]);
+			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",(double) selected_chart_data_cost_stats_.min[2],
+														(double) selected_chart_data_cost_stats_.max[2],
+														(double) selected_chart_data_cost_stats_.avg[2]);
 			ImGui::PushStyleColor(ImGuiCol_Text, labeling_colors_.color_as_ImVec4( (std::size_t) 3)); // change the text color
 			ImGui::SliderFloat("-Y",&new_data_cost_[3],0.0f,new_data_cost_upper_bound_);
 			ImGui::PopStyleColor();
 			ImGui::SameLine();
-			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",selected_chart_data_cost_stats_.min[3],
-														selected_chart_data_cost_stats_.max[3],
-														selected_chart_data_cost_stats_.avg[3]);
+			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",(double) selected_chart_data_cost_stats_.min[3],
+														(double) selected_chart_data_cost_stats_.max[3],
+														(double) selected_chart_data_cost_stats_.avg[3]);
 			ImGui::PushStyleColor(ImGuiCol_Text, labeling_colors_.color_as_ImVec4( (std::size_t) 4)); // change the text color
 			ImGui::SliderFloat("+Z",&new_data_cost_[4],0.0f,new_data_cost_upper_bound_);
 			ImGui::PopStyleColor();
 			ImGui::SameLine();
-			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",selected_chart_data_cost_stats_.min[4],
-														selected_chart_data_cost_stats_.max[4],
-														selected_chart_data_cost_stats_.avg[4]);
+			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",(double) selected_chart_data_cost_stats_.min[4],
+														(double) selected_chart_data_cost_stats_.max[4],
+														(double) selected_chart_data_cost_stats_.avg[4]);
 			ImGui::PushStyleColor(ImGuiCol_Text, labeling_colors_.color_as_ImVec4( (std::size_t) 5)); // change the text color
 			ImGui::SliderFloat("-Z",&new_data_cost_[5],0.0f,new_data_cost_upper_bound_);
 			ImGui::PopStyleColor();
 			ImGui::SameLine();
-			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",selected_chart_data_cost_stats_.min[5],
-														selected_chart_data_cost_stats_.max[5],
-														selected_chart_data_cost_stats_.avg[5]);
+			ImGui::Text("min:%6.2f max:%6.2f avg:%6.2f",(double) selected_chart_data_cost_stats_.min[5],
+														(double) selected_chart_data_cost_stats_.max[5],
+														(double) selected_chart_data_cost_stats_.avg[5]);
 			if(ImGui::Button("Apply")) {
 				std::array<float,6> per_label_shift = {
 					new_data_cost_[0] - selected_chart_data_cost_stats_.avg[0],
@@ -196,7 +196,7 @@ class GraphCutLabelingApp : public LabelingViewerApp {
 				gcl.neighbors__set__compactness_based(compactness_coeff_);
 				for(index_t f : static_labeling_graph_.charts[selected_chart_].facets) { // for each facet of the current chart
 					FOR(l,6) {
-						GraphCutLabeling::shift_data_cost(data_cost_,f,l,per_label_shift[l]); // modify the local data cost vector
+						GraphCutLabeling::shift_data_cost(data_cost_,(GCoptimization::SiteID) f,l,per_label_shift[l]); // modify the local data cost vector
 					}
 				}
 				gcl.data_cost__set__all_at_once(data_cost_); // use the local data cost vector in the optimization

ext/GraphCutOptimization/CMakeLists.txt

@@ -7,6 +7,7 @@ SET(GCO_HEADERS
     src/graph.h
     src/block.h
     src/GCoptimization.h
+    src/energy.h
 )
 
 SET(GCO_SOURCES

ext/GraphCutOptimization/src/GCoptimization.cpp

@@ -89,36 +89,38 @@ void GCException::Report()
 GCoptimization::GCoptimization(SiteID nSites, LabelID nLabels) 
 : m_num_labels(nLabels)
 , m_num_sites(nSites)
+, m_labeling(new LabelID[nSites])
+, m_lookupSiteVar(new SiteID[nSites])
+, m_labelTable(new LabelID[nLabels])
+, m_stepsThisCycle(0)
+, m_stepsThisCycleTotal(0)
+, m_random_label_order(false)
 , m_datacostIndividual(0)
 , m_smoothcostIndividual(0)
+, m_labelingDataCosts(new EnergyTermType[nSites])
+, m_labelCounts(new SiteID[nLabels])
+, m_activeLabelCounts(new SiteID[m_num_labels])
 , m_labelcostsAll(0)
 , m_labelcostsByLabel(0)
 , m_labelcostCount(0)
-, m_smoothcostFn(0)
+, m_labelingInfoDirty(true)
+, m_verbosity(0)
 , m_datacostFn(0)
+, m_smoothcostFn(0)
+, m_beforeExpansionEnergy(0)
+, m_numNeighbors(0)
 , m_numNeighborsTotal(0)
+, m_giveSmoothEnergyInternal(0)
 , m_queryActiveSitesExpansion(&GCoptimization::queryActiveSitesExpansion<DataCostFnFromArray>)
-, m_setupDataCostsSwap(0)
 , m_setupDataCostsExpansion(0)
-, m_setupSmoothCostsSwap(0)
 , m_setupSmoothCostsExpansion(0)
+, m_setupDataCostsSwap(0)
+, m_setupSmoothCostsSwap(0)
 , m_applyNewLabeling(0)
 , m_updateLabelingDataCosts(0)
-, m_giveSmoothEnergyInternal(0)
-, m_solveSpecialCases(&GCoptimization::solveSpecialCases<DataCostFnFromArray>)
 , m_datacostFnDelete(0)
 , m_smoothcostFnDelete(0)
-, m_random_label_order(false)
-, m_verbosity(0)
-, m_labelingInfoDirty(true)
-, m_lookupSiteVar(new SiteID[nSites])
-, m_labeling(new LabelID[nSites])
-, m_labelTable(new LabelID[nLabels])
-, m_labelingDataCosts(new EnergyTermType[nSites])
-, m_labelCounts(new SiteID[nLabels])
-, m_activeLabelCounts(new SiteID[m_num_labels])
-, m_stepsThisCycle(0)
-, m_stepsThisCycleTotal(0)
+, m_solveSpecialCases(&GCoptimization::solveSpecialCases<DataCostFnFromArray>)
 {
 	if ( nLabels <= 1 ) handleError("Number of labels must be >= 2");
 	if ( nSites <= 0 )  handleError("Number of sites must be >= 1");
@@ -132,8 +134,8 @@ GCoptimization::GCoptimization(SiteID nSites, LabelID nLabels)
 		handleError("Not enough memory.");
 	}
 
-	memset(m_labeling, 0, m_num_sites*sizeof(LabelID));
-	memset(m_lookupSiteVar,-1,m_num_sites*sizeof(SiteID));
+	memset(m_labeling, 0, (size_t) m_num_sites * sizeof(LabelID));
+	memset(m_lookupSiteVar,-1, (size_t) m_num_sites * sizeof(SiteID));
 	setLabelOrder(false);
 	specializeSmoothCostFunctor(SmoothCostFnPotts());
 }
@@ -739,7 +741,7 @@ void GCoptimization::setDataCost(SiteID s, LabelID l, EnergyTermType e) {
 	if ( !m_datacostIndividual )
 	{
 		EnergyTermType* table = new EnergyTermType[m_num_sites*m_num_labels];
-		memset(table, 0, m_num_sites*m_num_labels*sizeof(EnergyTermType));
+		memset(table, 0, (size_t) m_num_sites * (size_t) m_num_labels * sizeof(EnergyTermType));
 		specializeDataCostFunctor(DataCostFnFromArray(table, m_num_labels));
 		m_datacostIndividual = table;
 		m_labelingInfoDirty = true;
@@ -807,7 +809,7 @@ void GCoptimization::setSmoothCost(LabelID l1, LabelID l2, EnergyTermType e){
 	if ( !m_smoothcostIndividual )
 	{
 		EnergyTermType* table = new EnergyTermType[m_num_labels*m_num_labels];
-		memset(table, 0, m_num_labels*m_num_labels*sizeof(EnergyTermType));
+		memset(table, 0, (size_t) m_num_labels * (size_t) m_num_labels * sizeof(EnergyTermType));
 		specializeSmoothCostFunctor(SmoothCostFnFromArray(table, m_num_labels));
 		m_smoothcostIndividual = table;
 	} 
@@ -864,13 +866,13 @@ void GCoptimization::setLabelSubsetCost(LabelID* labels, LabelID numLabels, Ener
 
 	if ( !m_labelcostsByLabel ) {
 		m_labelcostsByLabel = new LabelCostIter*[m_num_labels];
-		memset(m_labelcostsByLabel, 0, m_num_labels*sizeof(void*));
+		memset(m_labelcostsByLabel, 0, (size_t) m_num_labels*sizeof(void*));
 	}
 
 	// If this particular subset already has a cost, simply replace it.
 	for ( LabelCostIter* lci = m_labelcostsByLabel[labels[0]]; lci; lci = lci->next ) {
 		if ( numLabels == lci->node->numLabels ) {
-			if ( !memcmp(labels, lci->node->labels, numLabels*sizeof(LabelID)) ) {
+			if ( !memcmp(labels, lci->node->labels, (size_t) numLabels * sizeof(LabelID)) ) {
 				// This label subset already exists, so just update the cost and return
 				lci->node->cost = cost;
 				return;
@@ -889,7 +891,7 @@ void GCoptimization::setLabelSubsetCost(LabelID* labels, LabelID numLabels, Ener
 	lc->aux = -1;
 	lc->numLabels = numLabels;
 	lc->labels = new LabelID[numLabels];
-	memcpy(lc->labels, labels, numLabels*sizeof(LabelID));
+	memcpy(lc->labels, labels, (size_t) numLabels * sizeof(LabelID));
 	slist_prepend(m_labelcostsAll, lc);
 	for ( LabelID i = 0; i < numLabels; ++i ) {
 		LabelCostIter* lci = new LabelCostIter;
@@ -903,7 +905,7 @@ void GCoptimization::setLabelSubsetCost(LabelID* labels, LabelID numLabels, Ener
 void GCoptimization::whatLabel(SiteID start, SiteID count, LabelID* labeling)
 {
 	assert(start >= 0 && start+count <= m_num_sites);
-	memcpy(labeling, m_labeling+start, count*sizeof(LabelID));
+	memcpy(labeling, m_labeling+start, (size_t) count * sizeof(LabelID));
 }
 
 //-------------------------------------------------------------------
@@ -1062,8 +1064,8 @@ void GCoptimization::setLabelOrder(const LabelID* order, LabelID size)
 		if ( order[i] < 0 || order[i] >= m_num_labels )
 			handleError("Invalid label id in setLabelOrder");
 	m_random_label_order = false;
-	memcpy(m_labelTable,order,size*sizeof(LabelID));
-	memset(m_labelTable+size,-1,(m_num_labels-size)*sizeof(LabelID));
+	memcpy(m_labelTable,order, (size_t) size * sizeof(LabelID));
+	memset(m_labelTable+size,-1, (size_t) (m_num_labels-size) * sizeof(LabelID));
 }
 
 //------------------------------------------------------------------
@@ -1103,7 +1105,7 @@ GCoptimization::EnergyType GCoptimization::setupLabelCostsExpansion(SiteID size,
 	{
 		// For sparse data costs, things are more complicated, because we must ensure that
 		// no label cost for a fixed (non-active) non-alpha label is encoded in the graph.
-		memset(m_activeLabelCounts,0,m_num_labels*sizeof(SiteID));
+		memset(m_activeLabelCounts,0, (size_t) m_num_labels * sizeof(SiteID));
 		for ( SiteID i = 0; i < size; ++i )
 			m_activeLabelCounts[m_labeling[activeSites[i]]]++;
 
@@ -1164,7 +1166,7 @@ void GCoptimization::updateLabelingInfo(bool updateCounts, bool updateActive, bo
 	{
 		if ( updateCounts )
 		{
-			memset(m_labelCounts,0,m_num_labels*sizeof(SiteID));
+			memset(m_labelCounts,0, (size_t) m_num_labels * sizeof(SiteID));
 			for ( SiteID i = 0; i < m_num_sites; ++i )
 				m_labelCounts[m_labeling[i]]++;
 		}
@@ -1173,8 +1175,7 @@ void GCoptimization::updateLabelingInfo(bool updateCounts, bool updateActive, bo
 		{
 			for ( LabelCost* lc = m_labelcostsAll; lc; lc = lc->next )
 				lc->active = false;
-
-			EnergyType energy = 0;
+			
 			for ( LabelID l = 0; l < m_num_labels; ++l ) 
 				if ( m_labelCounts[l] )
 					for ( LabelCostIter* lci = m_labelcostsByLabel[l]; lci; lci = lci->next ) 
@@ -1187,7 +1188,7 @@ void GCoptimization::updateLabelingInfo(bool updateCounts, bool updateActive, bo
 		if (m_updateLabelingDataCosts)
 			(this->*m_updateLabelingDataCosts)();
 		else
-			memset(m_labelingDataCosts,0,m_num_sites*sizeof(EnergyTermType));
+			memset(m_labelingDataCosts,0, (size_t) m_num_sites * sizeof(EnergyTermType));
 	}
 }
 
@@ -1776,14 +1777,14 @@ void GCoptimization::DataCostFnSparse::set(LabelID l, const SparseDataCost* cost
 	//
 	if (!m_buckets) {
 		m_buckets = new DataCostBucket[m_num_labels*m_buckets_per_label];
-		memset(m_buckets, 0, m_num_labels*m_buckets_per_label*sizeof(DataCostBucket));
+		memset(m_buckets, 0, (size_t) m_num_labels * (size_t) m_buckets_per_label * sizeof(DataCostBucket));
 	}
 
 	DataCostBucket* b = &m_buckets[l*m_buckets_per_label];
 	if (b->begin)
 		delete [] b->begin;
 	SparseDataCost* next = new SparseDataCost[count];
-	memcpy(next,costs,count*sizeof(SparseDataCost));
+	memcpy(next,costs, (size_t) count * sizeof(SparseDataCost));
 
 	//
 	// Scan the list of costs and remember pointers to delimit the 'buckets', i.e. where 

ext/GraphCutOptimization/src/GCoptimization.h

@@ -110,6 +110,10 @@
 #include "graph.cpp"
 #include "maxflow.cpp"
 
+// remove compiler warning about unused parameter
+template <class T>
+inline void ignore_unused(const T&) {}
+
 /////////////////////////////////////////////////////////////////////
 // Utility functions, classes, and macros
 /////////////////////////////////////////////////////////////////////
@@ -212,6 +216,7 @@ class GCoptimization
 	void setDataCostFunctor(DataCostFunctor* f);
 	struct DataCostFunctor {
 		virtual EnergyTermType compute(SiteID s, LabelID l) = 0;
+		virtual ~DataCostFunctor() = default; // fixes -Wnon-virtual-dtor
 	};
 	// Set cost of assigning 'l' to a specific subset of sites.
 	// The sites are listed as (SiteID,cost) pairs.
@@ -230,6 +235,7 @@ class GCoptimization
 	void setSmoothCostFunctor(SmoothCostFunctor* f);
 	struct SmoothCostFunctor {
 		virtual EnergyTermType compute(SiteID s1, SiteID s2, LabelID l1, LabelID l2) = 0;
+		virtual ~SmoothCostFunctor() = default; // fixes -Wnon-virtual-dtor
 	};
 
 	// Sets the cost of using label in the solution. 
@@ -358,7 +364,7 @@ class GCoptimization
 	struct SmoothCostFnFromArray {
 		SmoothCostFnFromArray(EnergyTermType* theArray, LabelID num_labels)
 			: m_array(theArray), m_num_labels(num_labels){}
-		OLGA_INLINE EnergyTermType compute(SiteID s1, SiteID s2, LabelID l1, LabelID l2){return m_array[l1*m_num_labels+l2];}
+		OLGA_INLINE EnergyTermType compute(SiteID s1, SiteID s2, LabelID l1, LabelID l2){ignore_unused(s1); ignore_unused(s2); return m_array[l1*m_num_labels+l2];}
 	private:
 		const EnergyTermType* const m_array;
 		const LabelID m_num_labels;
@@ -489,7 +495,7 @@ class GCoptimization
 	class GreedyIter {
 	public:
 		GreedyIter(DataCostT& dc, SiteID numSites)
-		: m_dc(dc), m_site(0), m_numSites(numSites), m_label(0), m_lbegin(0), m_lend(0)
+		: m_site(0), m_dc(dc), m_numSites(numSites), m_label(0), m_lbegin(0), m_lend(0)
 		{ }
 
 		OLGA_INLINE void start(const LabelID* labels, LabelID labelCount=1)

ext/GraphCutOptimization/src/LinkedBlockList.cpp

@@ -15,15 +15,15 @@ void LinkedBlockList::addFront(ListType item) {
 		m_head_block_size = 0;
 	}
 
-	m_head ->m_item[m_head_block_size] = item;
+	m_head ->m_item[(unsigned char) m_head_block_size] = item;
 	m_head_block_size++;
 }
 
 /*********************************************************************/
 
 ListType LinkedBlockList::next()
 {
-	ListType toReturn = m_cursor -> m_item[m_cursor_ind];
+	ListType toReturn = m_cursor -> m_item[(unsigned char) m_cursor_ind];
 
 	m_cursor_ind++;