Skip to content

Commit 960b4b5

Browse files
committed
Fixed test scores min max range
1 parent acebdb3 commit 960b4b5

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ repos:
4242
name: Sort imports
4343

4444
- repo: https://github.com/charliermarsh/ruff-pre-commit
45-
rev: v0.11.13
45+
rev: v0.12.8
4646
hooks:
4747
- id: ruff
4848
args: [--exit-non-zero-on-fix, --fix, --line-length=180]

pythresh/thresholds/clf.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,14 @@ def eval(self, decision):
9797

9898
pdf = self._kde.pdf(decision)
9999
pdf = self._set_norm(pdf, '_knorm')
100+
pdf[pdf < 0] = 0
100101

101102
pdf = pdf**(1/10)
102103
pdf = self._set_norm(pdf, '_pnorm')
103104

104105
log = np.log(decision + 1)
105106
log = self._set_norm(log, '_lnorm')
107+
log[log < 0] = 0
106108

107109
pred = self.m1*decision + self.m2*log + self.m3*pdf + self.c
108110

pythresh/thresholds/meta.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ def eval(self, decision):
146146

147147
pdf = self._kde.pdf(decision)
148148
pdf = self._set_norm(pdf, '_knorm')
149+
pdf[pdf < 0] = 0
149150

150151
for i in range(len(model.groups_)):
151152

pythresh/thresholds/ocsvm.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,9 @@ def eval(self, decision):
160160
self._clf = clf
161161

162162
# Predict inliers and outliers
163-
res = self._clf.predict(decision)
163+
evaluate = decision.copy()
164+
evaluate[evaluate < 0] = 0
165+
res = self._clf.predict(evaluate)
164166

165167
res[res == -1] = 0
166168

pythresh/thresholds/thresh_utility.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ def normalize(data, min_val=None, max_val=None):
1919
if min_val is None or max_val is None:
2020
min_val, max_val = get_min_max(data)
2121

22-
# Adjust test data to be 0 or greater to avoid method failures
2322
normed = (data - min_val) / (max_val - min_val)
24-
normed[normed < 0] = 0
2523

2624
return normed
2725

0 commit comments

Comments
 (0)