Skip to content

Commit 50d9c18

Browse files
committed
Mute SEGFAULT recovery tests.
Several tests in CrashRecoveryTest become invalid after the commit of "Disable signal handling of JVM GC signals".
1 parent 8f7f9e8 commit 50d9c18

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

llvm/unittests/Support/CrashRecoveryTest.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,12 @@ static void incrementGlobal() { ++GlobalInt; }
3939
static void llvmTrap() { LLVM_BUILTIN_TRAP; }
4040
static void incrementGlobalWithParam(void *) { ++GlobalInt; }
4141

42+
#define SKIP_WITH_KOTLIN_PATCH() \
43+
GTEST_SKIP() << "Crash recovery from SEGFAULT disabled by Kotlin patch"
44+
4245
TEST(CrashRecoveryTest, Basic) {
46+
SKIP_WITH_KOTLIN_PATCH();
47+
4348
llvm::CrashRecoveryContext::Enable();
4449
GlobalInt = 0;
4550
EXPECT_TRUE(CrashRecoveryContext().RunSafely(incrementGlobal));
@@ -57,6 +62,8 @@ struct IncrementGlobalCleanup : CrashRecoveryContextCleanup {
5762
static void noop() {}
5863

5964
TEST(CrashRecoveryTest, Cleanup) {
65+
SKIP_WITH_KOTLIN_PATCH();
66+
6067
llvm::CrashRecoveryContext::Enable();
6168
GlobalInt = 0;
6269
{
@@ -77,6 +84,8 @@ TEST(CrashRecoveryTest, Cleanup) {
7784
}
7885

7986
TEST(CrashRecoveryTest, DumpStackCleanup) {
87+
SKIP_WITH_KOTLIN_PATCH();
88+
8089
SmallString<128> Filename;
8190
std::error_code EC = sys::fs::createTemporaryFile("crash", "test", Filename);
8291
EXPECT_FALSE(EC);

0 commit comments

Comments
 (0)