Configure output directory for dumps #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
approved these changes
Jan 18, 2024
| @@ -150,10 +158,10 @@ private class TargetConfig constructor( | |||
| val apiDir | |||
There was a problem hiding this comment.
Could you please move the property above the fun block?
| val root = project.layout.projectDirectory.asFile.toPath().toAbsolutePath().normalize() | ||
| val resolvedDir = root.resolve(dir).normalize() | ||
| if (!resolvedDir.startsWith(root)) { | ||
| throw IllegalArgumentException("apiDumpDirectory should be inside the project directory") |
There was a problem hiding this comment.
Please consider enriching the message with the contextual information about expected and actual paths
Co-authored-by: Vsevolod Tolstopyatov <[email protected]>
|
(I removed the obsolete comment because I was looking at the wrong branch in my IDE) |
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
* Support output directory configuration Fixes Kotlin/binary-compatibility-validator#127 --------- Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#170
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
* Support output directory configuration Fixes Kotlin/binary-compatibility-validator#127 --------- Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#170
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
* Support output directory configuration Fixes Kotlin/binary-compatibility-validator#127 --------- Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#170
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
* Support output directory configuration Fixes Kotlin/binary-compatibility-validator#127 --------- Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#170 Moved from Kotlin/binary-compatibility-validator@4367cb7
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
* Support output directory configuration Fixes Kotlin/binary-compatibility-validator#127 --------- Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#170 Moved from Kotlin/binary-compatibility-validator@4367cb7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to configure a path to a directory where dumps are stored:
By default, that path remains
api.It's an error to specify a path that leads outside the project directory.
Fixes #127