Merged
Conversation
added 2 commits
August 17, 2023 20:30
Signed-off-by: huxiangyuan <huxiangyuan@harmonycloud.cn>
Signed-off-by: huxiangyuan <huxiangyuan@harmonycloud.cn>
added 2 commits
August 18, 2023 09:09
Signed-off-by: huxiangyuan <huxiangyuan@harmonycloud.cn>
Signed-off-by: huxiangyuan <huxiangyuan@harmonycloud.cn>
dxsup
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Issue-547
Motivation and Context
Qr in Rfc-2929
many DNS implementations copy the query header as the initial value of the response header without clearing bits.
Thus any attempt to use a "query" bit with a different meaning in a response or to define a query meaning for a "response" bit is dangerous given existing implementation.
Besides, the order of request and response with id may be out of order, eg.
req1 req2 req3 resp2 req4 resp1 resp2 resp4
How Has This Been Tested?
--- PASS: TestDnsProtocol (0.01s)
--- PASS: TestDnsProtocol/bad-qr (0.00s)
--- PASS: TestDnsProtocol/multi (0.00s)
--- PASS: TestDnsProtocol/sendmmsg (0.00s)
--- PASS: TestDnsProtocol/tcp_not_found (0.00s)
PASS