practices: Avoid null pApplicationInfo deref

mark-lunarg · mark-lunarg · commit df79eff135bf · 2020-06-03T09:35:13.000-06:00
Change-Id: Ia535aea6177ebdb01bf1f14b423522178a6c980f
diff --git a/layers/best_practices_utils.cpp b/layers/best_practices_utils.cpp
@@ -139,8 +139,9 @@ bool BestPractices::PreCallValidateCreateInstance(const VkInstanceCreateInfo* pC
                                "vkCreateInstance(): Attempting to enable Device Extension %s at CreateInstance time.",
                                pCreateInfo->ppEnabledExtensionNames[i]);
         }
-        skip |= ValidateDeprecatedExtensions("CreateInstance", pCreateInfo->ppEnabledExtensionNames[i],
-                                             pCreateInfo->pApplicationInfo->apiVersion,
+        uint32_t specified_version =
+            (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);
+        skip |= ValidateDeprecatedExtensions("CreateInstance", pCreateInfo->ppEnabledExtensionNames[i], specified_version,
                                              kVUID_BestPractices_CreateInstance_DeprecatedExtension);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,9 @@ bool BestPractices::PreCallValidateCreateInstance(const VkInstanceCreateInfo* pC`
`139`	`139`	`"vkCreateInstance(): Attempting to enable Device Extension %s at CreateInstance time.",`
`140`	`140`	`pCreateInfo->ppEnabledExtensionNames[i]);`
`141`	`141`	`}`
`142`		`- skip \|= ValidateDeprecatedExtensions("CreateInstance", pCreateInfo->ppEnabledExtensionNames[i],`
`143`		`- pCreateInfo->pApplicationInfo->apiVersion,`
	`142`	`+ uint32_t specified_version =`
	`143`	`+ (pCreateInfo->pApplicationInfo ? pCreateInfo->pApplicationInfo->apiVersion : VK_API_VERSION_1_0);`
	`144`	`+ skip \|= ValidateDeprecatedExtensions("CreateInstance", pCreateInfo->ppEnabledExtensionNames[i], specified_version,`
`144`	`145`	`kVUID_BestPractices_CreateInstance_DeprecatedExtension);`
`145`	`146`	`}`
`146`	`147`