Export svgGeometry to @flow.#936
Merged
k4b7 merged 1 commit intoKaTeX:masterfrom Oct 15, 2017
marcianx:flow-svgGeometry
Merged
Conversation
k4b7
reviewed
Oct 15, 2017
src/svgGeometry.js
Outdated
| const path: {[string]: string} = { | ||
| // sqrtMain path geometry is from glyph U221A in the font KaTeX Main | ||
| sqrtMain: `M95 622c-2.667 0-7.167-2.667-13.5 | ||
| "sqrtMain": `M95 622c-2.667 0-7.167-2.667-13.5 |
Member
There was a problem hiding this comment.
I tried this in the flow demo and it works without the quotes: https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVBjOA7AzgFzCjjgC4wBvAbQICcBLbAcwF1y7GmBfMAXktRgwAD3IByYWIA0gsAE9xc6ai4BuVEA
Collaborator
Author
There was a problem hiding this comment.
Updated to remove all the quotes I introduced in this commit. I was just a little surprised that all these unquoted keys worked as I'm used to the Google Closure Compiler that renames struct fields but not string keys.
k4b7
approved these changes
Oct 15, 2017
Member
k4b7
left a comment
k4b7
left a comment
There was a problem hiding this comment.
LGTM. Thanks for switching the keys back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Straightforward constant-only file. I was explicit with the type as I've become more paranoid about flow's type inference. However, I'm also happy to remove it if you prefer.