Skip to content

Solve Safari rendering issues with font-size overrides.#780

Merged
k4b7 merged 1 commit intoKaTeX:masterfrom
kohler:fix-shrinkwrap
Aug 2, 2017
Merged

Solve Safari rendering issues with font-size overrides.#780
k4b7 merged 1 commit intoKaTeX:masterfrom
kohler:fix-shrinkwrap

Conversation

@kohler
Copy link
Copy Markdown
Collaborator

@kohler kohler commented Aug 1, 2017

Some delicate surgery is required on the vlist-s table-cell CSS.
Problem with #768 reported by @ronkok; issue #779. Fixes:

  • font-size: 1px (rather than font-size: 0.05em) solves render
    issues with user overrides of the .katex font-size.
  • Also fix a width issue.

Some delicate surgery is required on the `vlist-s` table-cell CSS.
Problem with KaTeX#768 reported by @ronkok; issue KaTeX#779. Fixes:

* `font-size: 1px` (rather than `font-size: 0.05em`) solves render
  issues with user overrides of the `.katex` `font-size`.
* Also fix a width issue.
@kohler kohler requested a review from k4b7 August 1, 2017 21:24
@ronkok
Copy link
Copy Markdown
Collaborator

ronkok commented Aug 1, 2017

This looks great to me. I've checked it in Safari Mac, Safari iOS, Chrome, Firefox, Opera, IE 9-11, and Edge. Rendering looks good in all of them.

Copy link
Copy Markdown
Member

@k4b7 k4b7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// issues; absolute units prevent user font-size overrides from breaking
// rendering. Safari refuses to make the box zero-width, so we give it
// a known width and compensate with negative right margin on the
// inline-table.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice comment

@k4b7
Copy link
Copy Markdown
Member

k4b7 commented Aug 2, 2017

@kohler thanks for the quick fix. @ronkok thanks for checking the rendering in all those browsers.

@k4b7 k4b7 merged commit 766487b into KaTeX:master Aug 2, 2017
@kohler kohler deleted the fix-shrinkwrap branch August 5, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants