Skip to content

Commit a276380

Browse files
committed
Bug Fix: App crashes when download error occurs
1 parent 91569c2 commit a276380

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

app/src/main/java/com/junkfood/seal/BaseApplication.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,10 @@ import android.content.Context
77
import android.os.Build
88
import android.os.Environment
99
import com.google.android.material.color.DynamicColors
10-
import com.junkfood.seal.util.DownloadUtil
1110
import com.junkfood.seal.util.NotificationUtil
1211
import com.junkfood.seal.util.PreferenceUtil
1312
import com.junkfood.seal.util.PreferenceUtil.AUDIO_DIRECTORY
1413
import com.junkfood.seal.util.PreferenceUtil.VIDEO_DIRECTORY
15-
import com.junkfood.seal.util.PreferenceUtil.YT_DLP
1614
import com.tencent.mmkv.MMKV
1715
import com.yausername.ffmpeg.FFmpeg
1816
import com.yausername.youtubedl_android.YoutubeDL
@@ -34,9 +32,6 @@ class BaseApplication : Application() {
3432
try {
3533
YoutubeDL.getInstance().init(this@BaseApplication)
3634
FFmpeg.getInstance().init(this@BaseApplication)
37-
if (PreferenceUtil.getString(YT_DLP).isNullOrEmpty()) {
38-
DownloadUtil.updateYtDlp()
39-
}
4035
} catch (e: YoutubeDLException) {
4136
e.printStackTrace()
4237
}

app/src/main/java/com/junkfood/seal/MainActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ class MainActivity : AppCompatActivity() {
107107
}
108108

109109
fun stopService() {
110+
if (!isServiceRunning) return
110111
context.unbindService(connection)
111112
isServiceRunning = false
112113
}

app/src/main/java/com/junkfood/seal/ui/page/download/DownloadViewModel.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,11 @@ class DownloadViewModel @Inject constructor() : ViewModel() {
174174

175175
viewModelScope.launch(Dispatchers.IO) {
176176
if (!checkStateBeforeDownload()) return@launch
177-
downloadVideo(stateFlow.value.url)
177+
try {
178+
downloadVideo(stateFlow.value.url)
179+
} catch (e: Exception) {
180+
manageDownloadError(e)
181+
}
178182
finishProcessing()
179183
}
180184
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1+
Bug Fix: App crashes when download error occurs
12
Add Danish translations by @comradekingu
23
Add Spanish translations by @BobbyESP
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Open-source video/audio downloader for Android, designed and themed with Material-You.
1+
Video/Audio downloader designed and themed with Material You

0 commit comments

Comments
 (0)