Skip to content

Commit 8f02d35

Browse files
vignesh-kydnath
authored andcommitted
Fix for issues #35, #37, #38 (#40)
Issue #35 : For fields which are not predefined in %methods, use the input as it is without changing _ to -. Issue #37 : Included quotes Issue #38 : Commented out the print statement. Additional change : Commented out 'Disconnecting' carp call.
1 parent 77dbf9a commit 8f02d35

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/Net/Netconf/Device.pm

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ sub disconnect
279279
{
280280
my($self) = @_;
281281
my $conn = $self->{'conn_obj'};
282-
carp "Disconnecting\n";
282+
#carp "Disconnecting\n";
283283
$conn->disconnect if ($conn and $self->{'conn_state'} !=
284284
Net::Netconf::Constants::NC_STATE_DISCONN && not $conn->eof);
285285
$self->{'conn_obj'} = undef;
@@ -419,7 +419,7 @@ sub parse_response
419419
# This is useful for <get> and <get-config> operations
420420
sub get_dom
421421
{
422-
print "inside dom object";
422+
#print "inside dom object";
423423
my($self) = @_;
424424
# Create a DOM object and return that.
425425
# Server response is in: $self->{server_response}
@@ -563,7 +563,7 @@ sub generate_rpc
563563
$output .= "\n";
564564

565565
} else {
566-
$output .= " <${tag}>${value}</${tag}>\n";
566+
$output .= " <${field}>${value}</${field}>\n";
567567
}
568568
}
569569
if ($bindings->{'tag_name'}) {
@@ -605,7 +605,7 @@ sub get_config
605605
$request .= $args{'source'};
606606
$request .= '/> </source>';
607607
}
608-
$request .= $args{filter};
608+
$request .= $args{'filter'};
609609
$request .= '</get-config> </rpc>';
610610
$self->send_and_recv_rpc($request);
611611
}

0 commit comments

Comments
 (0)