Minor changes to windows installer, icons, and shortcuts

(cherry picked from commit 6998c4a)

Author: musm

contrib/windows/build-installer.nsi

@@ -52,7 +52,7 @@ FunctionEnd
 Function createDesktopLink
   ${NSD_GetState} $Checkbox $0
   ${If} $0 <> 0
-    CreateShortCut "$DESKTOP\julia.lnk" "$INSTDIR\bin\julia.exe"
+    CreateShortCut "$DESKTOP\julia.lnk" "$INSTDIR\bin\julia.exe" "" "$INSTDIR\bin\julia.exe" 0
   ${EndIf}
 FunctionEnd
 
@@ -107,7 +107,7 @@ Section "Dummy Section" SecDummy
     SetOutPath $INSTDIR
     File /a /r "julia-${Commit}\*"
     WriteUninstaller "$INSTDIR\uninstall.exe"
-    CreateShortcut "$INSTDIR\julia.lnk" "$INSTDIR\bin\julia.exe"
+    CreateShortcut "$INSTDIR\julia.lnk" "$INSTDIR\bin\julia.exe" "" "$INSTDIR\bin\julia.exe" 0
 
     # ARP entries
     WriteRegStr HKCU "${ARP}" \

contrib/windows/icon-readme.md

@@ -0,0 +1,23 @@
+
+Generate the logo
+```julia
+using Luxor
+Drawing(325, 325, joinpath(pwd(), "julia-dots.svg"))
+origin()
+translate(0, 25)
+juliacircles(100)
+finish()
+```
+
+Create the ico file
+```sh
+#!/bin/bash
+
+for size in 16 20 24 32 40 48 64 128 256; do
+    rsvg-convert -w $size -h $size julia-dots.svg -o $size.png
+done
+
+convert 256.png 128.png 64.png 48.png 40.png 32.png 24.png 20.png 16.png julia.ico
+
+rm 256.png 128.png 64.png 48.png 40.png 32.png 24.png 20.png 16.png
+```

contrib/windows/julia.ico

@@ -18,7 +18,7 @@ BEGIN
       VALUE "FileDescription", "Julia Programming Language"
       VALUE "FileVersion", JLVER_STR
       VALUE "InternalName", "julia"
-      VALUE "LegalCopyright", "MIT Licensed"
+      VALUE "LegalCopyright", "(c) 2009-2019 Julia Language"
       VALUE "OriginalFilename", "julia.exe"
       VALUE "ProductName", "Julia"
       VALUE "ProductVersion", JLVER_STR