Bug fix pecuzal kwa (#80)

* fixed tests w.r.t. deprecations in Peaks

* removed typo in key-word argument; revised test

* version increment; changelog

Author: hkraemer

CHANGELOG.md

@@ -1,3 +1,6 @@
+# v1.20.1
+* Patch for correct keyword arguments in PECUZAL algorithm
+
 # v1.20.0
 * Revised version of PECUZAL algorithm, now tracking maximal L-decrease
 

Project.toml

@@ -1,7 +1,7 @@
 name = "DelayEmbeddings"
 uuid = "5732040d-69e3-5649-938a-b6b4f237613f"
 repo = "https://github.com/JuliaDynamics/DelayEmbeddings.jl.git"
-version = "1.20.0"
+version = "1.20.1"
 
 [deps]
 Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7"

src/unified_de/pecuzal.jl

@@ -129,14 +129,14 @@ function pecuzal_embedding(s::Vector{T}; τs = 0:50 , w::Int = 1,
 end
 
 function pecuzal_embedding(Y::Dataset{D, T}; τs = 0:50 , w::Int = 1,
-    samplesize::Real = 1, K::Int = 13, KNN::Int = 3, threshold::Real = 0,
+    samplesize::Real = 1, K::Int = 13, KNN::Int = 3, L_threshold::Real = 0,
     α::Real = 0.05, p::Real = 0.5, max_cycles::Int = 50, econ::Bool = false
     ) where {D, T<:Real}
 
     @assert 0 < samplesize ≤ 1 "Please select a valid `samplesize`, which denotes a fraction of considered fiducial points, i.e. `samplesize` ∈ (0 1]"
     @assert all(x -> x ≥ 0, τs)
-    @assert threshold ≥ 0
-    threshold = -threshold # due to the negativity of L-decrease
+    @assert L_threshold ≥ 0
+    threshold = -L_threshold # due to the negativity of L-decrease
     metric = Euclidean()
 
     Y_orig = Y

test/test_pecuzal_embedding.jl

@@ -67,7 +67,7 @@ end
     @test -0.015 < Ls[4] < -0.014
 
     @time Y, τ_vals, ts_vals, Ls , ε★ = pecuzal_embedding(tr[1:5000,:];
-                                        τs = 0:Tmax , w = w, econ = true, threshold = 0.2)
+                                        τs = 0:Tmax , w = w, econ = true, L_threshold = 0.2)
     @test -0.9338 < Ls[1] < -0.9337
     @test -0.356 < Ls[2] < -0.355
     @test size(Y,2) == 3