Skip to content

Commit b2b65b6

Browse files
committed
4259 add types for isOptionDisabledType
1 parent aff92d8 commit b2b65b6

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

packages/react-select/src/Select.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ import type {
5656
FocusEventHandler,
5757
GroupType,
5858
InputActionMeta,
59+
isOptionDisabledType,
5960
KeyboardEventHandler,
6061
MenuPlacement,
6162
MenuPosition,
@@ -163,7 +164,7 @@ export type Props = {
163164
164165
An example can be found in the [Replacing builtins](/advanced#replacing-builtins) documentation.
165166
*/
166-
isOptionDisabled: (OptionType, OptionsType) => boolean | false,
167+
isOptionDisabled: isOptionDisabledType,
167168
/* Override the built-in logic to detect whether an option is selected */
168169
isOptionSelected?: (OptionType, OptionsType) => boolean,
169170
/* Support multiple selected options */
@@ -870,7 +871,7 @@ export default class Select extends Component<Props, State> {
870871

871872
return isClearable;
872873
}
873-
isOptionDisabled(option: OptionType, selectValue: OptionsType, isOptionDisabledFunc: isOptionDisabled): boolean {
874+
isOptionDisabled(option: OptionType, selectValue: OptionsType, isOptionDisabledFunc: isOptionDisabledType): boolean {
874875
return typeof isOptionDisabledFunc === 'function'
875876
? isOptionDisabledFunc(option, selectValue)
876877
: false;

packages/react-select/src/__tests__/Select.test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,6 @@ cases(
629629
menuIsOpen: true,
630630
hideSelectedOptions: false,
631631
isMulti: true,
632-
menuIsOpen: true,
633632
};
634633
let { container } = render(<Select {...props} />);
635634

packages/react-select/src/types.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,3 +120,5 @@ export type OptionProps = PropsWithInnerRef & {
120120
onMouseOver: MouseEventHandler,
121121
value: any,
122122
};
123+
124+
export type isOptionDisabledType = (OptionType, OptionsType) => boolean;

0 commit comments

Comments
 (0)