fix(core): parse astro script as TS (biomejs#7878)

ematipico · coderabbitai[bot] · Jagget · commit 5061b5ff7b97 · 2025-10-27T09:57:04.000-04:00
Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;
diff --git a/.changeset/ten-hoops-unite.md b/.changeset/ten-hoops-unite.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#7857](https://github.com/biomejs/biome/issues/7857): Biome now parses `<script>` tags as TypeScript when analysing `.astro` files.
diff --git a/crates/biome_cli/tests/cases/handle_astro_files.rs b/crates/biome_cli/tests/cases/handle_astro_files.rs
@@ -56,6 +56,20 @@ const { some } = Astro.props
 ---
 <div>{some}</div>"#;
 
+const ASTRO_FILE_WITH_TS_SCRIPT_TAG: &str = r#"---
+const title = "My Page";
+---
+<html>
+<body>
+    <script>
+        const message:     string = "Hello TypeScript";
+        function greet(name:   string): void {
+            console.log(  message + ", " + name );
+        }
+    </script>
+</body>
+</html>"#;
+
 #[test]
 fn format_astro_files() {
     let fs = MemoryFileSystem::default();
@@ -620,3 +634,36 @@ fn astro_global_object() {
         result,
     ));
 }
+
+#[test]
+fn format_astro_with_typescript_script_tag() {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    fs.insert(
+        "biome.json".into(),
+        r#"{ "html": { "formatter": {"enabled": true}, "linter": {"enabled": true}, "experimentalFullSupportEnabled": true } }"#.as_bytes(),
+    );
+
+    let astro_file_path = Utf8Path::new("file.astro");
+    fs.insert(
+        astro_file_path.into(),
+        ASTRO_FILE_WITH_TS_SCRIPT_TAG.as_bytes(),
+    );
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(["format", "--write", astro_file_path.as_str()].as_slice()),
+    );
+
+    assert!(result.is_ok(), "run_cli returned {result:?}");
+
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "format_astro_with_typescript_script_tag",
+        fs,
+        console,
+        result,
+    ));
+}
diff --git a/crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/format_astro_with_typescript_script_tag.snap b/crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/format_astro_with_typescript_script_tag.snap
@@ -0,0 +1,40 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+  "html": {
+    "formatter": { "enabled": true },
+    "linter": { "enabled": true },
+    "experimentalFullSupportEnabled": true
+  }
+}
+```
+
+## `file.astro`
+
+```astro
+---
+const title = "My Page";
+---
+<html>
+	<body>
+		<script>
+		const message: string = "Hello TypeScript";
+		function greet(name: string): void {
+			console.log(message + ", " + name);
+		}
+		</script>
+	</body>
+</html>
+
+```
+
+# Emitted Messages
+
+```block
+Formatted 1 file in <TIME>. Fixed 1 file.
+```
diff --git a/crates/biome_service/src/file_handlers/html.rs b/crates/biome_service/src/file_handlers/html.rs
@@ -488,6 +488,8 @@ pub(crate) fn parse_embedded_script(
                 file_source = file_source.with_embedding_kind(EmbeddingKind::Vue);
             }
             file_source
+        } else if html_file_source.is_astro() {
+            JsFileSource::ts().with_embedding_kind(EmbeddingKind::Astro)
         } else {
             let is_module = element.is_javascript_module().unwrap_or_default();
             if is_module {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@biomejs/biome": patch
 +---
++
 +Fixed [#7857](https://github.com/biomejs/biome/issues/7857): Biome now parses `<script>` tags as TypeScript when analysing `.astro` files.
Original file line number	Diff line number	Diff line change
`@@ -488,6 +488,8 @@ pub(crate) fn parse_embedded_script(`
`488`	`488`	`file_source = file_source.with_embedding_kind(EmbeddingKind::Vue);`
`489`	`489`	`}`
`490`	`490`	`file_source`
	`491`	`+ } else if html_file_source.is_astro() {`
	`492`	`+ JsFileSource::ts().with_embedding_kind(EmbeddingKind::Astro)`
`491`	`493`	`} else {`
`492`	`494`	`let is_module = element.is_javascript_module().unwrap_or_default();`
`493`	`495`	`if is_module {`