Remove "Match category" from localization (#11626)

* remove "Match category"

* JavaDoc

Author: LoayGhreeb

src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java

@@ -145,14 +145,15 @@ public static void setExactWidth(TableColumn<?, ?> column, double width) {
         column.setMaxWidth(width);
     }
 
+    /**
+     * Creates a column for the match category.
+     * <p>This column is always hidden but is used for sorting the table
+     * in the floating mode. The order of the {@link MatchCategory} enum constants
+     * determines the sorting order.</p>
+     */
     private TableColumn<BibEntryTableViewModel, MatchCategory> createMatchCategoryColumn(MainTableColumnModel columnModel) {
         TableColumn<BibEntryTableViewModel, MatchCategory> column = new MainTableColumn<>(columnModel);
-        Node header = new Text(Localization.lang("Match category"));
-        header.getStyleClass().add("mainTable-header");
-        Tooltip.install(header, new Tooltip(MainTableColumnModel.Type.MATCH_CATEGORY.getDisplayName()));
-        column.setGraphic(header);
         column.setCellValueFactory(cellData -> cellData.getValue().matchCategory());
-        new ValueTableCellFactory<BibEntryTableViewModel, MatchCategory>().withText(String::valueOf).install(column);
         column.setSortable(true);
         column.setSortType(TableColumn.SortType.ASCENDING);
         column.setVisible(false);

src/main/java/org/jabref/gui/maintable/MainTableColumnModel.java

@@ -35,7 +35,7 @@ public class MainTableColumnModel {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(MainTableColumnModel.class);
     public enum Type {
-        MATCH_CATEGORY("match_category", Localization.lang("Match category")),
+        MATCH_CATEGORY("match_category"), // Not localized, because this column is always hidden
         INDEX("index", Localization.lang("Index")),
         EXTRAFILE("extrafile", Localization.lang("File type")),
         FILES("files", Localization.lang("Linked files")),

src/main/java/org/jabref/gui/search/MatchCategory.java

@@ -1,5 +1,8 @@
 package org.jabref.gui.search;
 
+/**
+ * @implNote The order of constants in this enum is important because it is used for sorting the main table.
+ */
 public enum MatchCategory {
     MATCHING_SEARCH_AND_GROUPS,
     MATCHING_SEARCH_NOT_GROUPS,

src/main/resources/l10n/JabRef_en.properties

@@ -823,7 +823,6 @@ Character\ encoding\ '%0'\ is\ not\ supported.=Character encoding '%0' is not su
 Filter\ search\ results=Filter search results
 Filter\ by\ groups=Filter by groups
 Invert\ groups=Invert groups
-Match\ category=Match category
 Scroll\ to\ previous\ match\ category=Scroll to previous match category
 Scroll\ to\ next\ match\ category=Scroll to next match category
 Search=Search