s7generic does not work properly, switch back to 1500 as a target (#524)

* Create draft PR for #523

* Back to 1500 target

* Back to 1500 target

Author: TomKovac

scripts/commit_and_ready_for_review.ps1

@@ -0,0 +1,16 @@
+if (-not $args[0]) 
+{
+    $commitMessage = Read-Host "Please provide a commit message." 
+}
+else
+{
+    $commitMessage = $args[0]
+}
+git add .
+git commit -m "$commitMessage"
+git push
+# Get the current script directory
+$scriptDir = Split-Path -Path $MyInvocation.MyCommand.Definition -Parent
+# Construct the full path to ready_for_review.ps1
+$ready_for_reviewScriptPath = Join-Path -Path $scriptDir -ChildPath "ready_for_review.ps1"
+& $ready_for_reviewScriptPath

…tku_you_plus_the_other_if_neccessary.ps1 scripts/ready_for_review.ps1scripts/ready_for_review_ptku_you_plus_the_other_if_neccessary.ps1 renamed to scripts/ready_for_review.ps1 scripts/ready_for_review_ptku_you_plus_the_other_if_neccessary.ps1 renamed to scripts/ready_for_review.ps1

@@ -26,11 +26,31 @@ else
     # Assign it to me
     gh pr edit $pullRequestNumber --add-assignee "@me"
     Write-Host "Please enter the additional reviewers names: i.e.: my_boss_github_name, his_boss_github_name, etc. (upto the galaxy owner)"
-    $AdditionalReviewers = Read-Host "At least one additional reviewer's github name must be provided."
+    Write-Host "If environment variable 'GH_REVIEWERS' exists, these names will be added, otherwise these names will be used as the only reviewers"
+    $AdditionalReviewers = Read-Host "For empty press enter."
     $ReviewComment = Read-Host "Please enter a comment for the reviewers, for empty press enter"
     Write-Output "currentBranch:  $currentBranch"
-    Write-Output "AdditionalReviewers:  $AdditionalReviewers"
-    $Reviewers = "PTKu" + "," + $AdditionalReviewers
+    if ($Env:GH_REVIEWERS -ne $null) 
+    {
+        if (-not $AdditionalReviewers) 
+        {
+            $Reviewers = $Env:GH_REVIEWERS 
+        }
+        else
+        {
+            $Reviewers = $Env:GH_REVIEWERS + "," + $AdditionalReviewers
+        }
+    } 
+    else 
+    {
+        $Reviewers = $AdditionalReviewers
+    }
+    if (-not $Reviewers) 
+    {
+        Write-Error "No reviewers defined."
+        exit 1
+    }
+    Write-Output "Reviewers:  $Reviewers"
     $ReviewersArray = $Reviewers -split "," | ForEach-Object { $_.Trim() }
     $ReviewersString = $ReviewersArray -join ","
     $Command = "gh pr edit --add-reviewer " + $ReviewersString

src/abstractions/app/apax.yml

@@ -3,7 +3,7 @@ version: '0.0.0-dev.0'
 type: app
 targets:
   - llvm
-  - s7generic
+  - "1500"
 variables:
   APAX_BUILD_ARGS:
     - "--debug" # Generate debug information for target "1500"

src/components.abb.robotics/app/apax.yml

@@ -2,7 +2,7 @@ name: "app_axopen.components.abb.robotics"
 version: '0.0.0-dev.0'
 type: app
 targets:
-  - s7generic
+  - "1500"
 variables:
   APAX_BUILD_ARGS:
     - "--debug" # Generate debug information for target "1500"

src/components.abstractions/app/apax.yml

@@ -3,7 +3,7 @@ version: '0.0.0-dev.0'
 type: app
 targets:
   - llvm
-  - s7generic
+  - "1500"
 variables:
   APAX_BUILD_ARGS:
     - "--debug" # Generate debug information for target "1500"

src/components.balluff.identification/app/apax.yml

@@ -2,7 +2,7 @@ name: "app_axopen.components.balluff.identification"
 version: '0.0.0-dev.0'
 type: app
 targets:
-  - s7generic
+  - "1500"
 variables:
   APAX_BUILD_ARGS:
     - "--debug" # Generate debug information for target "1500"

src/components.cognex.vision/app/apax.yml

@@ -2,7 +2,7 @@ name: "app_axopen.components.cognex.vision"
 version: '0.0.0-dev.0'
 type: app
 targets:
-  - s7generic
+  - "1500"
 variables:
   APAX_BUILD_ARGS:
     - "--debug" # Generate debug information for target "1500"

src/components.desoutter.tightening/app/apax.yml

@@ -2,7 +2,7 @@ name: "app_axopen.components.desoutter.tightening"
 version: '0.0.0-dev.0'
 type: app
 targets:
-  - s7generic
+  - "1500"
 variables:
   APAX_BUILD_ARGS:
     - "--debug" # Generate debug information for target "1500"

src/components.drives/app/apax.yml

@@ -3,7 +3,7 @@ version: '0.0.0-dev.0'
 type: app
 targets:
   - llvm
-  - s7generic
+  - "1500"
 variables:
   APAX_BUILD_ARGS:
     - "--debug" # Generate debug information for target "1500"

src/components.elements/app/apax.yml

@@ -2,7 +2,7 @@ name: "elementscomponents"
 version: '0.0.0-dev.0'
 type: app
 targets:
-  - s7generic
+  - "1500"
   - llvm
 variables:
   APAX_BUILD_ARGS: