Skip to content

Commit 23ae172

Browse files
committed
Review fixes
1 parent bcf52e7 commit 23ae172

File tree

12 files changed

+25
-37
lines changed

12 files changed

+25
-37
lines changed

bench/tx-generator/src/Cardano/Benchmarking/Tracer.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import Cardano.Benchmarking.Version as Version
3434
import Cardano.Logging
3535
import qualified Cardano.Logging.Types as Net
3636
import Cardano.Node.Startup
37-
import Cardano.Node.Tracing.NodeInfo () -- MetaTrace NodeInfo
37+
import Cardano.Node.Tracing.NodeInfo ()
3838
import Ouroboros.Network.IOManager (IOManager)
3939

4040
import Control.Monad (forM, guard)
@@ -49,8 +49,8 @@ import qualified Data.Text as Text
4949
import Data.Time.Clock
5050
import GHC.Generics
5151

52+
import Trace.Forward.Forwarding (initForwardingDelayed)
5253
import Trace.Forward.Utils.TraceObject
53-
import Trace.Forward.Forwarding (initForwardingDelayed)
5454

5555
pattern TracerNameBench :: Text
5656
pattern TracerNameBench = "Benchmark"

cardano-node/src/Cardano/Node/Tracing/API.hs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ module Cardano.Node.Tracing.API
99
) where
1010

1111
import Cardano.Logging hiding (traceWith)
12-
import qualified Cardano.Logging.Types as Net
1312
import Cardano.Logging.Prometheus.TCPServer (runPrometheusSimple)
13+
import qualified Cardano.Logging.Types as Net
1414
import Cardano.Network.PeerSelection.PeerTrustable (PeerTrustable)
1515
import Cardano.Node.Configuration.NodeAddress (PortNumber)
1616
import Cardano.Node.Configuration.POM (NodeConfiguration (..))
@@ -51,8 +51,9 @@ import Data.Time.Clock (getCurrentTime)
5151
import Network.Mux.Trace (TraceLabelPeer (..))
5252
import Network.Socket (HostName)
5353
import System.Metrics as EKG
54-
import Trace.Forward.Forwarding (initForwardingDelayed)
55-
import Trace.Forward.Utils.TraceObject (writeToSink)
54+
55+
import Trace.Forward.Forwarding (initForwardingDelayed)
56+
import Trace.Forward.Utils.TraceObject (writeToSink)
5657

5758

5859
initTraceDispatcher ::

cardano-tracer/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# ChangeLog
22

3+
## 0.3.5
4+
* trace-forward now depends on trace-dispatcher, and not the other way around
5+
36
## 0.3.4 (July, 2025)
47
* Forwarding protocol supports connections over TCP socket, in addition to Unix domain sockets.
58

cardano-tracer/cardano-tracer.cabal

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
cabal-version: 3.0
22

33
name: cardano-tracer
4-
version: 0.3.3
4+
version: 0.3.5
55
synopsis: A service for logging and monitoring over Cardano nodes
66
description: A service for logging and monitoring over Cardano nodes.
77
category: Cardano,

cardano-tracer/src/Cardano/Tracer/Handlers/ReForwarder.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ module Cardano.Tracer.Handlers.ReForwarder
1515
( initReForwarder
1616
) where
1717

18-
import Trace.Forward.Forwarding
1918
import Cardano.Logging.Trace
2019
import Cardano.Logging.Tracer.DataPoint
2120
import qualified Cardano.Logging.Types as Log
@@ -29,8 +28,9 @@ import Control.Monad (when)
2928
import Data.List (isPrefixOf)
3029
import qualified Data.Text as Text
3130

31+
import Trace.Forward.Forwarding
32+
import Trace.Forward.Utils.ForwardSink (ForwardSink)
3233
import Trace.Forward.Utils.TraceObject (writeToSink)
33-
import Trace.Forward.Utils.ForwardSink (ForwardSink)
3434

3535
-- | Initialize the reforwarding service if configured to be active.
3636
-- Returns

cardano-tracer/test/cardano-tracer-test-ext.hs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ import qualified System.Process as Sys
2929

3030
import Test.Tasty
3131
import Test.Tasty.QuickCheck
32-
import Trace.Forward.Forwarding (initForwarding)
33-
import Trace.Forward.Utils.TraceObject (writeToSink)
32+
33+
import Trace.Forward.Forwarding (initForwarding)
34+
import Trace.Forward.Utils.TraceObject (writeToSink)
3435

3536
main :: IO ()
3637
main = do

kernel-resource-summary.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

trace-dispatcher/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Revision history for trace-dispatcher
22

3+
## 2.11.0 -- July, 2025
4+
* trace-forward now depends on trace-dispatcher, and not the other
5+
* improves the structure and metadata of the generated tracer documentation
6+
37
## 2.10.0 -- July, 2025
48
* Forwarding protocol supports connections over TCP socket, in addition to Unix domain sockets.
59
* Failure to initialise the `PrometheusSimple` backend is now lenient - i.e., won't result in an exception being propagated.

trace-dispatcher/trace-dispatcher.cabal

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
cabal-version: 3.0
22

33
name: trace-dispatcher
4-
version: 2.10.0
4+
version: 2.11.0
55
synopsis: Tracers for Cardano
66
description: Package for development of simple and efficient tracers
77
based on the arrow based contra-tracer package
@@ -82,7 +82,6 @@ library
8282
, http-date
8383
, io-classes
8484
, network
85-
, optparse-applicative
8685
, serialise
8786
, stm
8887
, text
@@ -130,18 +129,13 @@ test-suite trace-dispatcher-test
130129
, ekg-core
131130
, generic-data
132131
, hostname
133-
, optparse-applicative
134-
, ouroboros-network
135132
, text
136133
, stm
137134
, tasty
138135
, tasty-hunit
139136
, tasty-quickcheck
140137
, time
141138
, trace-dispatcher
142-
, unagi-chan
143-
, unliftio
144-
, unliftio-core
145139
, unordered-containers
146140
, utf8-string
147141
, yaml

trace-forward/src/Trace/Forward/Utils/DataPoint.hs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@ module Trace.Forward.Utils.DataPoint
1414
, askForDataPoints
1515
) where
1616

17+
import Cardano.Logging.Tracer.DataPoint
18+
1719
import Control.Concurrent.STM (atomically, check, orElse)
1820
import Control.Concurrent.STM.TMVar
1921
import Control.Concurrent.STM.TVar
2022
import Data.Aeson
2123
import qualified Data.Map.Strict as M
2224

23-
import Cardano.Logging.Tracer.DataPoint
2425
import Trace.Forward.Protocol.DataPoint.Forwarder
2526
import Trace.Forward.Protocol.DataPoint.Type
2627

0 commit comments

Comments
 (0)