Skip to content

Commit 36be89d

Browse files
Added javadoc comments to FlutterActivity and FlutterFragmentActivity. (flutter#12328)
1 parent ecab4f8 commit 36be89d

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

shell/platform/android/io/flutter/embedding/android/FlutterActivity.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,15 @@
187187
* android:value="true"
188188
* />
189189
* }
190+
* <p>
191+
* <strong>Alternative Activity</strong>
192+
* {@link FlutterFragmentActivity} is also available, which is similar to {@code FlutterActivity}
193+
* but it extends {@code FragmentActivity}. You should use {@code FlutterActivity}, if possible,
194+
* but if you need a {@code FragmentActivity} then you should use {@link FlutterFragmentActivity}.
190195
*/
196+
// A number of methods in this class have the same implementation as FlutterFragmentActivity. These
197+
// methods are duplicated for readability purposes. Be sure to replicate any change in this class in
198+
// FlutterFragmentActivity, too.
191199
public class FlutterActivity extends Activity
192200
implements FlutterActivityAndFragmentDelegate.Host,
193201
LifecycleOwner {

shell/platform/android/io/flutter/embedding/android/FlutterFragmentActivity.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@
5353
* is considered to be the standard, canonical implementation of a Flutter
5454
* {@code Activity}.
5555
*/
56+
// A number of methods in this class have the same implementation as FlutterActivity. These methods
57+
// are duplicated for readability purposes. Be sure to replicate any change in this class in
58+
// FlutterActivity, too.
5659
public class FlutterFragmentActivity extends FragmentActivity
5760
implements SplashScreenProvider,
5861
FlutterEngineProvider,

0 commit comments

Comments
 (0)