dev-cmd/bottle: fix relocatable bottling for GCC and Binutils on Linux #20738
+33
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since dc71b7c, bottles for GCC and Binutils are no longer relocatable due to a misplacement of the relevant code in `extend/os`. Fix this by moving the code to the correct location.
ZhongRuoyu
force-pushed
the
relocatable-gcc-binutils
branch
from
b030f8a to
3fbfff2
Compare
ZhongRuoyu
changed the title
p-linnane
approved these changes
Sep 20, 2025
This was referenced Sep 20, 2025
|
My bad, thanks for fix @ZhongRuoyu! |
|
No problem @MikeMcQuaid! I would have definitely made more mistakes if I were to do dc71b7c. I think ideally there could be a RuboCop that catches |
|
@ZhongRuoyu Thanks and good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Since dc71b7c, bottles for GCC and Binutils are no longer relocatable due to a misplacement of the relevant code in
extend/os. Fix this by moving the code to the correct location.