formula: handle future deprecation and disable dates

Author: cho-m

Library/Homebrew/formula.rb

@@ -4797,7 +4797,7 @@ def disable!(date:, because:, replacement: nil, replacement_formula: nil, replac
         @deprecation_reason = T.let(because, T.nilable(T.any(String, Symbol)))
         @deprecation_replacement_formula = T.let(replacement_formula.presence || replacement, T.nilable(String))
         @deprecation_replacement_cask = T.let(replacement_cask.presence || replacement, T.nilable(String))
-        @deprecated = T.let(true, T.nilable(T::Boolean))
+        @deprecated = T.let(true, T.nilable(T::Boolean)) if @deprecation_date.nil?
         return
       end
 

Library/Homebrew/test/formula_spec.rb

@@ -2053,4 +2053,44 @@ def install
       expect(f.class.preserve_rpath?).to be(false)
     end
   end
+
+  describe "#deprecated?" do
+    let(:f) do
+      formula "foo" do
+        url "foo-1.0"
+        deprecate! date: "2020-01-01", because: :unmaintained
+        disable! date: "2021-01-01", because: :unmaintained
+      end
+    end
+
+    it "is false before deprecate date" do
+      allow(Date).to receive(:today).and_return(Date.parse("2019-01-01"))
+      expect(f.deprecated?).to be(false)
+    end
+
+    it "is true on deprecate date" do
+      allow(Date).to receive(:today).and_return(Date.parse("2020-01-01"))
+      expect(f.deprecated?).to be(true)
+    end
+  end
+
+  describe "#disabled?" do
+    let(:f) do
+      formula "foo" do
+        url "foo-1.0"
+        deprecate! date: "2020-01-01", because: :unmaintained
+        disable! date: "2021-01-01", because: :unmaintained
+      end
+    end
+
+    it "is false between deprecate and disable date" do
+      allow(Date).to receive(:today).and_return(Date.parse("2020-06-01"))
+      expect(f.disabled?).to be(false)
+    end
+
+    it "is true on disable date" do
+      allow(Date).to receive(:today).and_return(Date.parse("2021-01-01"))
+      expect(f.disabled?).to be(true)
+    end
+  end
 end