First cut of moving 'login_item' from under the 'uninstall' block to the top-level

Fix issues found when running brew cli commands (upgrade, update, install)
Incorporate 'login_items' into 'info' command output (not yet verified)
Incorporate 'login_items' option for 'reinstall' command

WIP: Adding placeholder for using osascript to register/unregister login items
Mark for deprecation
Trying to fix broken unit test
Fix ruby version

Author: vraravam

.ruby-version

@@ -0,0 +1 @@
+3.4.4

Library/Homebrew/ast_constants.rb

@@ -7,6 +7,7 @@
   [{ name: :include,   type: :method_call }],
   [{ name: :desc,      type: :method_call }],
   [{ name: :homepage,  type: :method_call }],
+  [{ name: :login_items, type: :method_call }],
   [{ name: :url,       type: :method_call }],
   [{ name: :mirror,    type: :method_call }],
   [{ name: :version,   type: :method_call }],

Library/Homebrew/cask/artifact/abstract_uninstall.rb

@@ -20,6 +20,7 @@ class AbstractUninstall < AbstractArtifact
         :launchctl,
         :quit,
         :signal,
+        # odeprecated: deprecate when all casks have been migrated to top-level login_items
         :login_item,
         :kext,
         :script,
@@ -295,6 +296,7 @@ def uninstall_signal(*signals, command: nil, **_)
         end
       end
 
+      # TODO: Need to refer to attribute from the cask instead of this uninstall stanza
       def uninstall_login_item(*login_items, command: nil, successor: nil, **_)
         return if successor
 

Library/Homebrew/cask/cask.rb

@@ -326,6 +326,10 @@ def languages
       @languages ||= @dsl.languages
     end
 
+    def login_items
+      @login_items ||= @dsl.login_items
+    end
+
     def tap_git_head
       @tap_git_head ||= tap&.git_head
     rescue TapUnavailableError
@@ -336,6 +340,7 @@ def populate_from_api!(json_cask)
       raise ArgumentError, "Expected cask to be loaded from the API" unless loaded_from_api?
 
       @languages = json_cask.fetch(:languages, [])
+      @login_items = json_cask.fetch(:login_items, [])
       @tap_git_head = json_cask.fetch(:tap_git_head, "HEAD")
 
       @ruby_source_path = json_cask[:ruby_source_path]
@@ -405,6 +410,7 @@ def to_h
         "languages"                       => languages,
         "ruby_source_path"                => ruby_source_path,
         "ruby_source_checksum"            => ruby_source_checksum,
+        "login_items"                     => login_items,
       }
     end
 

Library/Homebrew/cask/cask_loader.rb

@@ -370,6 +370,7 @@ def load(config:)
           end
           desc json_cask[:desc]
           homepage json_cask[:homepage]
+          login_items json_cask[:login_items] if json_cask[:login_items].present?
 
           if (deprecation_date = json_cask[:deprecation_date].presence)
             reason = DeprecateDisable.to_reason_string_or_symbol json_cask[:deprecation_reason], type: :cask
@@ -381,7 +382,7 @@ def load(config:)
             disable! date: disable_date, because: reason
           end
 
-          auto_updates json_cask[:auto_updates] unless json_cask[:auto_updates].nil?
+          auto_updates json_cask[:auto_updates] if json_cask[:auto_updates].present?
           conflicts_with(**json_cask[:conflicts_with]) if json_cask[:conflicts_with].present?
 
           if json_cask[:depends_on].present?

Library/Homebrew/cask/dsl.rb

@@ -106,6 +106,7 @@ class DSL
       :no_autobump!,
       :autobump?,
       :no_autobump_message,
+      :login_items,
       :on_system_blocks_exist?,
       :on_system_block_min_os,
       :depends_on_set_in_block?,
@@ -241,6 +242,21 @@ def set_unique_stanza(stanza, should_return)
       raise CaskInvalidError.new(cask, "'#{stanza}' stanza failed with: #{e}")
     end
 
+    # Sets the cask's login items
+    #
+    # ### Example
+    #
+    # ```ruby
+    # login_items "Raycast"
+    # ```
+    #
+    # @api public
+    def login_items(login_items = nil)
+      return [] if login_items.nil?
+
+      set_unique_stanza(:login_items, login_items.nil?) { Array(login_items) }
+    end
+
     # Sets the cask's homepage.
     #
     # ### Example

Library/Homebrew/cask/info.rb

@@ -27,6 +27,8 @@ def self.get_info(cask)
       language = language_info(cask)
       output << language if language
       output << "#{artifact_info(cask)}\n"
+      login_items = login_items_info(cask)
+      output << login_items if login_items
       caveats = Installer.caveats(cask)
       output << caveats if caveats
       output
@@ -134,5 +136,15 @@ def self.artifact_info(cask)
       end
       artifact_output.freeze
     end
+
+    sig { params(cask: Cask).returns(T.nilable(String)) }
+    def self.login_items_info(cask)
+      return if cask.login_items.empty?
+
+      <<~EOS
+        #{ohai_title("Login Items")}
+        #{cask.login_items.join(", ")}
+      EOS
+    end
   end
 end

Library/Homebrew/cask/installer.rb

@@ -21,14 +21,15 @@ class Installer
         skip_cask_deps: T::Boolean, binaries: T::Boolean, verbose: T::Boolean, zap: T::Boolean,
         require_sha: T::Boolean, upgrade: T::Boolean, reinstall: T::Boolean, installed_as_dependency: T::Boolean,
         installed_on_request: T::Boolean, quarantine: T::Boolean, verify_download_integrity: T::Boolean,
-        quiet: T::Boolean, download_queue: T.nilable(Homebrew::DownloadQueue)
+        quiet: T::Boolean, download_queue: T.nilable(Homebrew::DownloadQueue), login_items: T::Boolean
       ).void
     }
     def initialize(cask, command: SystemCommand, force: false, adopt: false,
                    skip_cask_deps: false, binaries: true, verbose: false,
                    zap: false, require_sha: false, upgrade: false, reinstall: false,
                    installed_as_dependency: false, installed_on_request: true,
-                   quarantine: true, verify_download_integrity: true, quiet: false, download_queue: nil)
+                   quarantine: true, verify_download_integrity: true, quiet: false, download_queue: nil,
+                   login_items: false)
       @cask = cask
       @command = command
       @force = force
@@ -47,6 +48,7 @@ def initialize(cask, command: SystemCommand, force: false, adopt: false,
       @quiet = quiet
       @download_queue = download_queue
       @ran_prelude = T.let(false, T::Boolean)
+      @login_items = login_items
     end
 
     sig { returns(T::Boolean) }
@@ -64,6 +66,9 @@ def installed_as_dependency? = @installed_as_dependency
     sig { returns(T::Boolean) }
     def installed_on_request? = @installed_on_request
 
+    sig { returns(T::Boolean) }
+    def login_items? = @login_items
+
     sig { returns(T::Boolean) }
     def quarantine? = @quarantine
 
@@ -340,6 +345,17 @@ def install_artifacts(predecessor: nil)
         already_installed_artifacts.unshift(artifact)
       end
 
+      unless @cask.login_items.empty?
+        if login_items?
+          @cask.login_items.each do |lgi|
+            # TODO: register the login_items here using osascript
+            ohai "***** Will REGISTER login_item: #{lgi}"
+          end
+        else
+          ohai "Skipping processing of login_items"
+        end
+      end
+
       save_config_file
       save_download_sha if @cask.version.latest?
     rescue => e
@@ -584,6 +600,15 @@ def uninstall_artifacts(clear: false, successor: nil)
       odebug "Uninstalling artifacts"
       odebug "#{::Utils.pluralize("artifact", artifacts.length, include_count: true)} defined", artifacts
 
+      if login_items?
+        @cask.login_items.each do |lgi|
+          # TODO: unregister the login_items here using osascript
+          ohai "***** Will UNREGISTER login_item: #{lgi}"
+        end
+      else
+        ohai "Skipping processing of login_items"
+      end
+
       artifacts.each do |artifact|
         if artifact.respond_to?(:uninstall_phase)
           artifact = T.cast(

Library/Homebrew/cask/reinstall.rb

@@ -6,7 +6,7 @@ class Reinstall
     sig {
       params(
         casks: ::Cask::Cask, verbose: T::Boolean, force: T::Boolean, skip_cask_deps: T::Boolean, binaries: T::Boolean,
-        require_sha: T::Boolean, quarantine: T::Boolean, zap: T::Boolean
+        require_sha: T::Boolean, quarantine: T::Boolean, zap: T::Boolean, login_items: T::Boolean
       ).void
     }
     def self.reinstall_casks(
@@ -17,7 +17,8 @@ def self.reinstall_casks(
       binaries: false,
       require_sha: false,
       quarantine: false,
-      zap: false
+      zap: false,
+      login_items: true
     )
       require "cask/installer"
 
@@ -26,7 +27,7 @@ def self.reinstall_casks(
       download_queue = Homebrew::DownloadQueue.new(pour: true) if Homebrew::EnvConfig.download_concurrency > 1
       cask_installers = casks.map do |cask|
         Installer.new(cask, binaries:, verbose:, force:, skip_cask_deps:, require_sha:, reinstall: true,
-                      quarantine:, zap:, download_queue:)
+                      quarantine:, zap:, download_queue:, login_items:)
       end
 
       if download_queue

Library/Homebrew/cask/upgrade.rb

@@ -21,6 +21,7 @@ class Upgrade
         binaries:            T.nilable(T::Boolean),
         quarantine:          T.nilable(T::Boolean),
         require_sha:         T.nilable(T::Boolean),
+        login_items:         T.nilable(T::Boolean),
       ).returns(T::Boolean)
     }
     def self.upgrade_casks!(
@@ -36,7 +37,8 @@ def self.upgrade_casks!(
       quiet: false,
       binaries: nil,
       quarantine: nil,
-      require_sha: nil
+      require_sha: nil,
+      login_items: nil
     )
       quarantine = true if quarantine.nil?
 
@@ -148,7 +150,7 @@ def self.upgrade_casks!(
         upgrade_cask(
           old_cask, new_cask,
           binaries:, force:, skip_cask_deps:, verbose:,
-          quarantine:, require_sha:, download_queue:
+          quarantine:, require_sha:, download_queue:, login_items:
         )
       rescue => e
         new_exception = e.exception("#{new_cask.full_name}: #{e}")
@@ -172,14 +174,15 @@ def self.upgrade_casks!(
         force:          T.nilable(T::Boolean),
         quarantine:     T.nilable(T::Boolean),
         require_sha:    T.nilable(T::Boolean),
+        login_items:    T.nilable(T::Boolean),
         skip_cask_deps: T.nilable(T::Boolean),
         verbose:        T.nilable(T::Boolean),
         download_queue: T.nilable(Homebrew::DownloadQueue),
       ).void
     }
     def self.upgrade_cask(
       old_cask, new_cask,
-      binaries:, force:, quarantine:, require_sha:, skip_cask_deps:, verbose:, download_queue:
+      binaries:, force:, quarantine:, require_sha:, login_items:, skip_cask_deps:, verbose:, download_queue:
     )
       require "cask/installer"
 
@@ -208,6 +211,7 @@ def self.upgrade_cask(
         upgrade:        true,
         quarantine:,
         download_queue:,
+        login_items:,
       }.compact
 
       new_cask_installer =