Skip to content

Commit bea1596

Browse files
committed
test/github_runner_matrix: prevent dropping supported macOS versions from CI
We should bump `HOMEBREW_MACOS_OLDEST_SUPPORTED` first and make sure that bump goes out into a release tag before dropping CI in Homebrew/core. Otherwise, we end up with users getting errors about missing bottles. See, for example, Homebrew/homebrew-core#240857. We've made it very hard for users on OS versions newer than `HOMEBREW_MACOS_OLDEST_SUPPORTED` to *not* use bottles (because only bottles are supported), but that design assumes we have been building bottles for them. We should therefore make sure that users we stop building bottles for are always on a version older than `HOMEBREW_MACOS_OLDEST_SUPPORTED`.
1 parent ceaadf8 commit bea1596

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

Library/Homebrew/test/github_runner_matrix_spec.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,13 @@
3333
setup_test_runner_formula("testball-depender-newest", ["testball", { macos: symbol }])
3434
end
3535

36+
describe "OLDEST_HOMEBREW_CORE_MACOS_RUNNER" do
37+
it "is not newer than HOMEBREW_MACOS_OLDEST_SUPPORTED" do
38+
oldest_macos_runner = MacOSVersion.from_symbol(described_class::OLDEST_HOMEBREW_CORE_MACOS_RUNNER)
39+
expect(oldest_macos_runner).to be <= HOMEBREW_MACOS_OLDEST_SUPPORTED
40+
end
41+
end
42+
3643
describe "#active_runner_specs_hash" do
3744
it "returns an object that responds to `#to_json`" do
3845
expect(

0 commit comments

Comments
 (0)